Fix plisql tripword and wordtype package-datum handling - #1651
Conversation
- plisql_parse_tripword: return true only from the PKG_VAR case (matching plisql_parse_dblword); a non-variable package entry now falls through instead of returning true with wdatum->datum uninitialized - plisql_parse_wordtype: resolve PLISQL_DTYPE_PACKAGE_DATUM datums through pkgvar before reading datatype/notnull, avoiding a mis-cast of the package-datum struct Closes IvorySQL#1648
|
Warning Review limit reached
Next review available in: 30 seconds You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes #1648.
plisql_parse_tripword(src/pl/plisql/src/pl_comp.c):return truemoved into thePKG_VARcase (matchingplisql_parse_dblword); aa.b.creference resolving to a non-variable package entry now falls through instead of returning true withwdatum->datumuninitialized.plisql_parse_wordtype:PLISQL_DTYPE_PACKAGE_DATUMdatums (standard-package variables) are now resolved throughpkgvarbefore readingdatatype/notnull, instead of mis-casting the package-datum struct (wrong on 32-bit, luck-dependent on 64-bit).Test plan
make -C src/pl/plisql/src pl_comp.ocompiles cleanly.