Repository navigation
fix partial rotary factor - #3861
Merged
Merged
Conversation
littlegy
pushed a commit
to littlegy/lmdeploy
that referenced
this pull request
Sep 11, 2025
oliveagle
pushed a commit
to oliveagle/lmdeploy
that referenced
this pull request
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config may have
partial_rotary_factorattribute withoutrope_scalingattributes.e.g.
https://huggingface.co/zai-org/GLM-4-9B-0414/blob/main/config.json
https://huggingface.co/zai-org/GLM-4.5-Air/blob/main/config.json
Previous condition checks will miss
partial_rotary_factorin this case, which leads to incorrect rope calculations.Related
This PR is the pre-requisite of GLM4-0414, GLM-4.1V, GLM-4.5 (Air), etc