Ticket8780 alarms config#4
Open
Chsudeepta wants to merge 17 commits into
Open
Conversation
davidkeymer
requested changes
Jul 17, 2026
| str : A decompressed and unhexed version of the input string | ||
| """ | ||
|
|
||
| return zlib.decompress(binascii.unhexlify(value)).decode("utf-8") |
There was a problem hiding this comment.
If you really need this function, could you call the original dehex&decompress, then decode the result?
Please move type hints to function signature from docstring.
Contributor
Author
There was a problem hiding this comment.
The original method fails because of the type check -- Argument was type str, the method only expects bytes. Type hint removed.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
|
|
||
| def dehex_and_decompress_waveform_value(value: str) -> str: | ||
| """Decompresses the inputted waveform, assuming it is available as string. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added xsd changes to block to support alarm config.
To see the changes work, change the line git+https://github.com/ISISComputingGroup/server_common ; platform_system=="Windows"
by
git+https://github.com/ISISComputingGroup/server_common@Ticket8780_Alarms_Config ; platform_system=="Windows"
in \Instrument\Apps\Python3\package_builder and pip install.
You would then see the new xsd in \Instrument\Apps\Python3\Lib\site-packages\server_common\schema