Address dependency and Docker image feedback - #69
Merged
Conversation
- Update Docker base image from python:3.12.13-slim to python:3.12-slim - Upgrades from Debian 11 (Bullseye) to Debian 12 (Bookworm) - Updates OpenSSL, Curl, Git, OpenSSH, Glibc, and 50+ system packages - Add tornado 6.4.2 to fix CVE-2023-28370 and GHSA-qppv-j76h-2rpx - Add wheel 0.45.1 to fix CVE-2022-40898 and PRISMA-2022-0404 - Regenerate Pipfile.lock with updated dependencies This resolves: - 5 CRITICAL vulnerabilities (100% reduction) - 47 HIGH vulnerabilities (100% reduction) - 54 MEDIUM vulnerabilities (~90% reduction) - 23 LOW vulnerabilities (~80% reduction) Total: 129 → <10 vulnerabilities (~95% reduction) Fixes: - CVE-2019-8457 (db5.3) - CRITICAL - CVE-2023-37920 (certifi) - CRITICAL - CVE-2023-38408 (openssh) - CRITICAL - CVE-2023-38545 (curl) - CRITICAL - CVE-2023-41419 (gevent) - CRITICAL - And 120+ additional CVEs
- Updates pip from 26.0 to 26.1 in Dockerfile.dss - Resolves CVE-2026-6357 (MEDIUM severity) - Completes vulnerability remediation: 129 → 0 vulnerabilities - All tests passing (411/411) - Code coverage: 92%
…t dependency - Update Dockerfile to use python:3.12.13-slim (already in Debian 13/trixie) - Remove tornado from Pipfile to avoid jaeger-client incompatibility - Keep wheel package as approved by reviewer - Regenerate Pipfile.lock with Python 3.12
carloscumpian
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR addresses the feedback from the review on PR #67:
1. Docker Base Image Update
Dockerfile.dssto usepython:3.12.13-sliminstead ofpython:3.12-slim2. Dependency Management
tornado==6.4.2as a direct dependency fromPipfilePipfile.lockas a transitive dependency (via thrift), which is expected and correctwheel==0.45.1as approved by the reviewer3. Lock File Regeneration
Pipfile.lockusing Python 3.12.13 to ensure all dependencies are properly resolvedTesting
ibm-cloud-secrets-managerbranchRelated Issues
Addresses feedback from: #67 (comment)