This repository was archived by the owner on Apr 18, 2026. It is now read-only.
Add parsing rules, and a test case, for "Go panicing in a http handler" - #49
Merged
Merged
Conversation
qingling128
suggested changes
Aug 13, 2019
qingling128
left a comment
Contributor
There was a problem hiding this comment.
Sent some minor suggestion. BTW, this one seems to require rebasing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50.
When doing a test deployment of a fluentd container with this plugin baked in, I tried figuring out the correct configuration by spinning up a Go http server with a URL triggering a panic. It did take me quite a while to figure out why my panic stack traces were not being merged.
This PR adds the capability to merge panics triggered from within a http handler (and a test case).
The example HTTP handler I used to trigger the message is below: