Skip to content

placeholder: disable event acknowledgment by default - #126

Open
wehm2000 wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
wehm2000:fix-placeholder-event-ack
Open

wehm2000 wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
wehm2000:fix-placeholder-event-ack

Conversation

@wehm2000

@wehm2000 wehm2000 commented Nov 6, 2026

Copy link
Copy Markdown

Prevent placeholder revisions from acknowledging Pub/Sub and Eventarc deliveries before application code is deployed.

  • Add ACK_EVENTS; default to false in the placeholder image and true in hello.
  • Replace POST acknowledgment statuses with HTTP 503 while preserving handlers, logging, and response bodies.
  • Set ACK_EVENTS=true to restore previous behavior. Retries remain subject to source retention limits.

@google-cla

google-cla Bot commented Nov 6, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Add ACK_EVENTS to prevent placeholder revisions from consuming deliveries before application code is deployed. Preserve handlers and response bodies while replacing POST acknowledgment statuses with HTTP 503; retain the hello image's default behavior.
@wehm2000
wehm2000 force-pushed the fix-placeholder-event-ack branch from 86012bc to 10c4569 Compare November 6, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant