Skip to content

Mainline development mode - #950

Merged
JakeGinnivan merged 9 commits into
GitTools:masterfrom
JakeGinnivan:MainlineDevelopmentMode
Jul 20, 2016
Merged

JakeGinnivan merged 9 commits into
GitTools:masterfrom
JakeGinnivan:MainlineDevelopmentMode

Conversation

@JakeGinnivan

Copy link
Copy Markdown
Contributor

This builds on top of #832

It's pretty rough but will ship this as part of 4.0.0 beta if it looks ok

@pascalberger

Copy link
Copy Markdown
Member

The branching strategy images still contain -unstable tags. Since alpha is the default in this PR I would change this in the images too.

Comment thread src/GitVersionCore/AssemblyInfo.cs Outdated
[assembly: AssemblyProduct("GitVersion")]
[assembly: AssemblyVersion("1.0.0")]
[assembly: AssemblyFileVersion("1.0.0")]
[assembly: AssemblyVersion("4.0.0.0")]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this set through GitVersion in the build process and should be kept to 1.0.0 in the repo?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran build script locally, forgot to reset these changes

@pascalberger

Copy link
Copy Markdown
Member

We should also make sure to document the new mainline mode properly. There is already a mainline documentation available which should be updated with these changes.

@JakeGinnivan
JakeGinnivan force-pushed the MainlineDevelopmentMode branch from cba2bf7 to defc31b Compare July 19, 2016 14:44
@JakeGinnivan JakeGinnivan mentioned this pull request Jul 19, 2016
Comment thread docs/versioning-mode.md Outdated
As such we force a pre-release tag on all branches, this is fine for applications but can cause problems for libraries. As such this mode may or may not work for you, which leads us into a new mode in v4. Mainline development.

## Mainline development
Mainline development works more like the Continuous Delivery mode, except that it tells GitVersion to *infer* releases from from event.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: from from

@aarondandy

aarondandy commented Jul 19, 2016 •

Copy link
Copy Markdown

I did a local build and tried it out, worked great and as expected during my quick testing.

My 🍠

assembly-versioning-scheme: MajorMinorPatch
mode: Mainline
branches:
  master:
    tag: ''
ignore:
  sha: []

I did get two test failures though when running build.ps1:
Test Count: 451, Passed: 449, Failed: 2, Inconclusive: 0, Skipped: 0

1) Error : ConfigProviderTests.CanWriteOutEffectiveConfiguration
Shouldly.ShouldAssertException : Cannot find a difftool to use, please open an issue or a PR to add support for your dif
ftool.
2) Error : DocumentationTests.ConfigurationDocumentationIsUpToDate
Shouldly.ShouldAssertException : configurationDocumentationFile
    should contain (case insensitive comparison)
"**`no-bump-message:`**"
    but was actually
"# Configuration
GitVersion 3.0 is mainly powered by configuration and no longer has branching strat..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants