Rira 23 - #175
Merged
Merged
Rira 23#175
Conversation
- deleted unnecessary prints and comments - add dataset methods to GriseraAPI - fixed get_datasets - create_dataset and delete_dataset need to be fixed
grisera api communicates with graph api to create a dataset of given name
there is an error with indexes (hope to fix it on Monday): File "/app/database_service.py", line 89, in check_if_database_exists grisera-framework-graph_api-1 | for db in response['results'][0]['data']: grisera-framework-graph_api-1 | IndexError: list index out of range
Before the creation of the dataset, the system checks if the database with this name already exists. If so, the database is not created and the user receives an error with the error cause
Auto creation during creating new dataset
Hash_name will be used as an identifier for the dataset by user
…ed in correct dataset When the dataset is created, inside it 4 types of nodes are created (35 nodes in total): - Alias - Channel - Life Activity - Modality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During working on this branch my team was able to accomplish several goals:
Adding channels, modalities and life activities during creation of dataset
Adding hash name to dataset which can be used as a secret name of the dataset by user (the original name of the dataset is saved as an Alias node in the dataset during its creation)
Fixed tests