Repository navigation
Conversation
victorapm
requested review from
MelReyCG,
OmarDuran,
bd713,
dkachuma,
jhuang2601,
tjb-ltk and
wrtobin
as code owners
October 12, 2026 01:45
Contributor
|
There needs to be a test showing the problem. Initialization of the wellbore during first opening can be done a few ways, including a well estimator. Its not clear what is specifically being addressed in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In summary, this PR:
Additional details
Initially open wells were previously initialized during the first coupled solver step. At time zero, their pressure and component-density fields could therefore remain zero. This also omitted fluid already stored in the wells from the initial reservoir-plus-well inventory, making subsequent mass-balance comparisons misleading.
This patch initializes open wells after the reservoir fluid state and well separator models are available, using the existing well-initialization path. It evaluates the well and perforation schedules at time zero and validates the active well constraints before initialization. That validation establishes the phase indices needed by phase-rate controls.
Wells that are closed initially retain their deferred initialization until opening. New regressions verify that open wells have populated pressure and component densities before any solver step, while an initially closed well remains uninitialized.
Validation passed:
testOpenClosePerf,testReservoirCompositionalMultiphaseMSWells,testReservoirSinglePhaseMSWells, andtestThermalReservoirCompositionalMultiphaseMSWells.