Repository navigation
Conversation
- kNP and kNSplineP are now set identically: the max spline knot count by default, or N with -n N (minimum 2). f4d8e0e had made them differ by one, so -n 100 gave 99-point TGraphs in the ROOT file. - -w now writes the plots as PDF (TPDF); --ps keeps PostScript. - Document -n and -x (interpolation) in the header and PrintSyntax(); reject the *_PERIODIC interpolation types. - Comment out the unused xcls in the neutrino DIS sums (its only use, the charm skip, was commented out in b09a220) to silence a warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gspl2root: consistent graph point count, PDF plots, document
-n/-xProblem
Since
f4d8e0ebf, the two point counts ingSplineXml2Root.cxxdisagree by one, in opposite directions depending on-n:kNSplineP)-wplots (kNP)-n NSo
-n 100writes 99-point graphs, and-n 2divides by zero in the energy step.-nand-xare also undocumented.Changes (
src/Apps/gSplineXml2Root.cxxonly)kNPandkNSplinePare set identically: the max spline knot count by default, or N with-n N(minimum 2). This restores theddb79cd48behaviour, where (with-land a matching-erange) the points fall on the spline knots.-wnow writesxsec-splines-<probe>-<target>.pdfviaTPDF;--psgives the previous PostScript output. Drawing code is unchanged (TVirtualPS). An old build ignores--ps.-x <interpolation>(added inf4d8e0ebf): documented in the header andPrintSyntax()—TSpline3(default),TSpline5,LINEAR,POLYNOMIAL,CSPLINE,AKIMA. Notes that intervals next to a zero-valued knot are always linear.*_PERIODICtypes are now rejected with a fatal error, as they are not meaningful for cross sections.xclsin the neutrino DIS-sum loop (its only use, the charm skip, was commented out inb09a22022) is commented out alongside it. No C++17 attribute is used.Not changed
Since
b09a22022the neutrinodis_*sums include charm, while the charged-leptondis_em_p/dis_em_nsums still exclude it. Flagged here; left for a separate decision.Testing
-Wall -W -Wshadow).gspl2rootrun on a spline file: point counts with and without-n,-wPDF vs-w --pspages,-x AKIMA_PERIODICexits.🤖 Generated with Claude Code