Repository navigation
Sorting of config folder - #542
AndersenFred wants to merge 13 commits into
Conversation
|
I'm done, it works but while doing this I found that the file Additionally some algs were present multiple times (all linking the same xml file) which are removed now |
|
Those file still in config I left there on purpose as either multiple Models use them or they are not linked at all in the master config |
|
It's admirable to want to clean up the config directory; it was large and unwieldy. It would have been good to have brought the idea up in a forum (either a Core Developers meeting, or on slack) before you put all the effort into implementing it. This might have allowed others to make useful suggestions. The are a few minor things and one big show stopper.
The fundamental problem is changing <config alg="genie::LocalFGM"> LocalFGM.xml </config> to <config alg="genie::LocalFGM"> NuclearState/LocalFGM.xml </config> This very dangerously, and silently breaks many/most of the tunes. Take a representative tune: N24_20i N24_20i/N24_20i_02_11b N24_20i/N24_20i_02_11b/CommonParam.xml N24_20i/MECInteractionListGenerator.xml N24_20i/TuneGeneratorList.xml N24_20i/NucDeExcitationSim.xml N24_20i/README.md N24_20i/LocalFGM.xml N24_20i/ModelConfiguration.xml With the new One "solution" would be to make the change to the directory structure in the tune, but:
I think a more workable approach would be to revert pathlist += ":$GENIE/config/tunes"; This would allow a reorganization of our plethora of XML files, but leave the tune structure unchanged. Additionally, I'd remove the One additional thining I'd like to see (not your fault, but wildly overdue) is clearer documentation of the search order without having to read the code. The order currently is: |
nusense
left a comment
There was a problem hiding this comment.
Have a conversation with the wider collaboration.
See the above comment for current problems.
|
Thanks Robert, let's discuss this at the next meeting! |
|
I have adapted the changes |
I started to sort the config folder, by moving all tunes to their own folder and sorted the configs for each class into categories