Skip to content

Add timezone parsing - #52

Merged
naveensingh merged 3 commits into
FossifyOrg:masterfrom
alkim0:timezone
Mar 11, 2024
Merged

naveensingh merged 3 commits into
FossifyOrg:masterfrom
alkim0:timezone

Conversation

@alkim0

@alkim0 alkim0 commented Jan 9, 2024 •

Copy link
Copy Markdown
Contributor

Fixes SimpleMobileTools/Simple-Calendar#1249. It will also fix #71.

Two things to note:

  1. This doesn't parse BEGIN:VTIMEZONE and assumes the timezone is one of the known timezones (e.g., America/New_York). This is just to get things working and is what etar does right now.
  2. The imported event's timezone is not preserved; it's converted to the local timezone. I didn't want to think about what to do when DTSTART and DTEND have different timezones (technically possible), since the app only stores one timezone per event.

@naveensingh

Copy link
Copy Markdown
Member

Seems to work just fine, thanks for the fix :)

@naveensingh
naveensingh merged commit 0d617c1 into FossifyOrg:master Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TimeZone is wrong Timezone is ignored when importing an .ics file

2 participants