Repository navigation
test(quant): skip declined local checkpoints and label cache paths portably - #582
Draft
YevheniiKotyrlo wants to merge 1 commit into
Draft
YevheniiKotyrlo wants to merge 1 commit into
YevheniiKotyrlo wants to merge 1 commit into
Conversation
YevheniiKotyrlo
force-pushed
the
fix-test-quant-config-local-checkpoints
branch
from
October 6, 2026 10:54
64827fd to
5374f7e
Compare
KarrAcaRn
pushed a commit
to KarrAcaRn/FreeToken-ByAI
that referenced
this pull request
Oct 6, 2026
FlashML-org#618 deferred with FlashML-org#605 (pre-sm70 only); drafts FlashML-org#582, FlashML-org#583, FlashML-org#586, FlashML-org#613 deferred. Assisted-by: Claude Opus 5.5
KarrAcaRn
pushed a commit
to KarrAcaRn/FreeToken-ByAI
that referenced
this pull request
Oct 6, 2026
FlashML-org#586 A stale local pr/N ref (fetched without + before a rebase) gave their pre-rebase SHAs; the rebased heads carry the same changes. Assisted-by: Claude Opus 5.5
YevheniiKotyrlo
force-pushed
the
fix-test-quant-config-local-checkpoints
branch
from
October 13, 2026 14:06
5374f7e to
d2e4d10
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_scheme_for_agrees_with_the_stored_tensorsruns over every checkpoint in the local Hugging Face cache and/mnt/nvme/models, so what is on the machine decides whether it passes. Two things fail it for reasons outside the code under test:NotImplementedError: compressed-tensors weight scheme {...} is not supportedfromQuantConfig.from_hf. The test expects that only for methods in_UNSUPPORTED._labelfinds the repo withmodels--([^/]+)/snapshots, which never matches a Windows path, so every cache entry is labellednvme:<snapshot hash>.Solution
A
NotImplementedErrorfromfrom_hfskips the row and says why - a clean decline is the behaviour a declined scheme should have, and the skip keeps it visible under-rs._labelreads the repo from the path's parts, which is right on every platform.Verification
Windows 11, with the W4A16 snapshot in the cache: before,
1 failedas[nvme:124c14e7e8c7d2f5402933b9af368e772a9fcf0c[index-only]]; after, the row is[syvai/qwen3.8-27b-3090-fast-variant[index-only]]and skips withFreeToken declines this checkpoint: compressed-tensors weight scheme {...} is not supported.pytest tests/models/test_quant_config.py: 11 passed, 42 skipped; on Linux, whose cache holds no declined checkpoint, 11 passed and 42 skipped with or without this change.