Repository navigation
Document ParameterService and BuildContext and move them to Fallout.Build.Execution - #707
Open
dennisdoomen wants to merge 1 commit into
Open
dennisdoomen wants to merge 1 commit into
dennisdoomen wants to merge 1 commit into
Conversation
…uild.Execution - Rewrite the BuildContext docs in plain English and link the de-statification plan. - Document ParameterService and how each BuildContext owns one instance. - Move both types from Fallout.Common(.Execution) to Fallout.Build.Execution. - Remove ParameterService members that nothing calls. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
dennisdoomen
added
target/vCurrent
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the move of
ParameterServiceonto theBuildContext(FT-4, #309). Docs, namespace and dead-code cleanup only. No behavior change.What changed
BuildContextdocs in plain English. They now linkdocs/engine-de-statification.mdfor the plan.ParameterService. They explain the order of value sources and that eachBuildContextowns one instance.Fallout.Build.Execution. Both areinternal, so there is no public API change. Consumers got a newusing.ParameterServicemembers that nothing calls:IsParameterGetParameterMemberName(string)GetNamedArgument<T>overloads forExpressionandMemberInfoGetAllPositionalArguments<T>GetVariable<T>overloadsHasArgumentNotes for reviewers
Fallout.Buildstill useFallout.Common.*namespaces. This PR moves only the two types.GitRepositoryWorktreeSpecshas 3 failing tests. They fail the same way ondevelop.🤖 Generated with Claude Code