Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make valid profile strings load through the framework's converters and make GUID schemas describe the values the runtime reads.
What changed
Part of #667 (Enumeration profile loading and invalid-value handling).
Closes #701 (GUID schemas matching runtime strings).
Verification
All 250 Fallout.Build.Specs tests passed on Windows with .NET SDK 10.0.302. Regression checks fail with the original conversion and schema logic. Existing snapshots pass. The full contributor build.ps1 Test target also passed with this fix and the Windows executable-path fix: 830 passed, seven existing CI-environment tests skipped.
Two independent local agents reviewed the final commits and found no defects. The test audit removed four overlapping or development-only cases and assertions about unused definitions, type-array ordering and an unchanged terminal newline. Eight cases remain, covering actual profile files, numeric compatibility, consumer converter precedence, arrays, named-profile overrides, GUID schema shapes and raw LF output.
CodeRabbit and Macroscope were requested on the fork review copy. Neither has produced a review result so far.
Follow-up
The existing warning/default behavior for invalid profile values is unchanged. A fail-fast policy needs a separate compatibility decision.
Requested labels:
target/vCurrent,bug. The fork author cannot apply labels in this repository.The fork CI run currently reports
action_requiredwith no jobs. Please approve the run.