[arelchan]

Change description

Fixes raven tui failing with a "Node version too low (found 20.20.1, need >= 22)" error on machines that do have a recent Node installed (e.g. Homebrew node 26), while raven agent works fine.

Two bugs in find_node() (raven/cli/tui_commands.py):

1. No minimum-version filtering. It returned the first candidate whose --version merely parsed, regardless of _MIN_NODE_VERSION. The caller then rejected it if < 22 without ever asking for the next candidate -- so a too-old node in an earlier priority tier shadowed a valid newer one.
2. PATH probed with shutil.which("node"), which returns only the first hit. A stale < 22 node earlier on PATH (an old /usr/local/bin/node, an nvm/asdf shim, etc.) hid a newer node later on PATH.

Together: a user with node 26 on PATH but a 20.x earlier on PATH got "node too low". raven agent was unaffected (no Node needed), which made it look like a TUI/streaming problem.

Fix

• Enumerate every node on PATH (not just the first).
• Return the first candidate that meets _MIN_NODE_VERSION, in priority order (RAVEN_NODE -> venv -> PATH -> private runtime).
• Keep the highest below-minimum candidate so, when nothing qualifies, the caller still reports the real version (found 20.20.1, need >= 22) instead of a bare "not found".

Tests

Added to tests/test_cli_tui_bootstrap.py:

• test_find_node_skips_below_min_and_scans_all_path -- a 20.20.1 earlier on PATH + a 26.5.0 later => find_node returns 26.5.0.
• test_find_node_reports_below_min_when_nothing_qualifies -- only a 20.20.1 => returns it (so the caller can show the version).

Type of change

• Bug fix
• New feature
• Document
• Others

Checklists

Development

• Lint rules pass locally (ruff check / ruff format)
• Application changes have been tested thoroughly
• Automated tests covering modified code pass

Code review

• Pull request has a descriptive title and context useful to a reviewer

Related issues

Closes #198

Follow-up fix included (appended commit)

test_find_node_discovers_windows_private_runtime was failing on
non-Windows hosts (it mocked sys.platform="win32", but find_node keys its
Windows branches off os.name == "nt", so the mock never took effect). This
PR now also fixes it, replacing the earlier "flagged for a separate fix" note:

• Add a _is_windows() seam that find_node consults for its venv, PATH, and
  private-runtime platform checks.
• The test patches _is_windows instead of os.name -- patching os.name
  directly is not viable, since pathlib selects PosixPath/WindowsPath by
  os.name and would raise NotImplementedError on a POSIX host.

[0xKT]

Appended a commit (as maintainer) fixing the pre-existing
test_find_node_discovers_windows_private_runtime failure this PR flagged --
the sys.platform vs os.name mock mismatch. The fix adds a _is_windows()
seam that find_node consults for its venv, PATH, and private-runtime checks,
and the test patches that seam instead of os.name (patching os.name
directly makes pathlib instantiate an unusable WindowsPath on POSIX hosts).

Also linked #198 (the node-selection bug this PR fixes) via Closes #198 in
the description, and folded your "flagged for a separate fix" note into a
"follow-up fix included" section. Thanks for the clear write-up -- it made
this easy to fold in.