Repository navigation
revert: pr #9 native short-term memory + everos long-term consolidation - #12
Merged
Merged
Conversation
KevinHuSh
pushed a commit
to KevinHuSh/Raven
that referenced
this pull request
Sep 14, 2026
…_memory_recall revert: pr EverMind-AI#9 native short-term memory + everos long-term consolidation
KevinHuSh
pushed a commit
to KevinHuSh/Raven
that referenced
this pull request
Sep 14, 2026
…on the host's llm ## Summary Fixes EverMind-AI#12. Raven-Design runs on the host's model and credentials since the launcher retired its own-key path, but `raven onboard` was not updated: it still recommended `openai/gpt-5.6-sol via OpenRouter` (a model the product no longer runs), still took a key and wrote `DESIGN_API_KEY` to `.env` (never read again), and with no host provider key it offered only the own-key choice and printed the ready tick for a product whose launcher then exited. - `agents/raven-design/subagent.json` no longer carries `recommendedLlm`. A folder that recommends no model of its own has nothing to run on but the host's LLM, and the wizard now reads that: no own-key option, no recommended-model line, no key written. It is set up (ticked) when this raven has a key to lend, and reported not ready otherwise. Raven-PPT still recommends its own model and keeps the full menu, so the two products' difference is now stated by the manifest rather than assumed. - The two smaller items folded into the issue: the product's `tools.web.search.maxResults` leaf is removed from `agents/raven-design/config.json` because the launcher hands the product the host's `tools.web` wholesale (the identity test now asserts the trunk config carries no `tools.web`); the settings usage tile's missing-data note gains the one-line assertion from the !561 acceptance note, verified to fail when the element is removed. ## Type - [x] Fix - [ ] Feature - [ ] Docs - [ ] CI / tooling - [ ] Refactor - [ ] Other ## Verification - `pytest -q tests/test_cli_subagent_setup.py tests/test_agents_design_launcher.py tests/test_i18n_boundary.py tests/test_cli_onboard_commands.py`: 403 passed. Two new wizard tests: a folder without a model of its own is ticked on a host key with zero prompts and no `.env`; the same folder without a host key is reported not ready, zero prompts, no `.env`. - Every test file mentioning `recommendedLlm` (code, design, ppt, oncall launchers, wizard, install script): 194 passed, 1 skipped. `tests/test_subagent_raven_launcher.py tests/test_config_update_tools.py`: 57 passed. - `ui-web`: `vitest run src/features/settings/SettingsPage.test.tsx` 49 passed on the tree; with the `note` element deleted from `SettingsPage.tsx` exactly one test fails (`shows unknown tokens for an image model that only reports money`), so the new assertion pins the element. - `lint-imports`: 9 contracts kept, 0 broken. `ruff format --check` and `ruff check` over `raven` and `tests`: clean. The two new wizard strings carry `zh` entries in `raven/i18n/zh.py`. - [x] Relevant tests pass locally - [x] Relevant lint / type checks pass locally - [ ] User-facing docs or screenshots are updated when needed ## Risk - [x] Security impact considered - [x] Backward compatibility considered - [x] Rollback path is clear for risky changes User-visible change: `raven onboard` no longer asks for a Raven-Design key or recommends a model for it; an existing `DESIGN_API_KEY` line in `.env` is left in place and stays unread, as before this change. `product_state` is unchanged, so the roster still lists Raven-Design; only the wizard's tick now follows whether the host can lend a key. Rollback is a revert of the squash commit. ## Related Issues Fixes EverMind-AI#12
KevinHuSh
pushed a commit
to KevinHuSh/Raven
that referenced
this pull request
Sep 14, 2026
…on the host's llm ## Summary Fixes EverMind-AI#12. Raven-Design runs on the host's model and credentials since the launcher retired its own-key path, but `raven onboard` was not updated: it still recommended `openai/gpt-5.6-sol via OpenRouter` (a model the product no longer runs), still took a key and wrote `DESIGN_API_KEY` to `.env` (never read again), and with no host provider key it offered only the own-key choice and printed the ready tick for a product whose launcher then exited. - `agents/raven-design/subagent.json` no longer carries `recommendedLlm`. A folder that recommends no model of its own has nothing to run on but the host's LLM, and the wizard now reads that: no own-key option, no recommended-model line, no key written. It is set up (ticked) when this raven has a key to lend, and reported not ready otherwise. Raven-PPT still recommends its own model and keeps the full menu, so the two products' difference is now stated by the manifest rather than assumed. - The two smaller items folded into the issue: the product's `tools.web.search.maxResults` leaf is removed from `agents/raven-design/config.json` because the launcher hands the product the host's `tools.web` wholesale (the identity test now asserts the trunk config carries no `tools.web`); the settings usage tile's missing-data note gains the one-line assertion from the !561 acceptance note, verified to fail when the element is removed. ## Type - [x] Fix - [ ] Feature - [ ] Docs - [ ] CI / tooling - [ ] Refactor - [ ] Other ## Verification - `pytest -q tests/test_cli_subagent_setup.py tests/test_agents_design_launcher.py tests/test_i18n_boundary.py tests/test_cli_onboard_commands.py`: 403 passed. Two new wizard tests: a folder without a model of its own is ticked on a host key with zero prompts and no `.env`; the same folder without a host key is reported not ready, zero prompts, no `.env`. - Every test file mentioning `recommendedLlm` (code, design, ppt, oncall launchers, wizard, install script): 194 passed, 1 skipped. `tests/test_subagent_raven_launcher.py tests/test_config_update_tools.py`: 57 passed. - `ui-web`: `vitest run src/features/settings/SettingsPage.test.tsx` 49 passed on the tree; with the `note` element deleted from `SettingsPage.tsx` exactly one test fails (`shows unknown tokens for an image model that only reports money`), so the new assertion pins the element. - `lint-imports`: 9 contracts kept, 0 broken. `ruff format --check` and `ruff check` over `raven` and `tests`: clean. The two new wizard strings carry `zh` entries in `raven/i18n/zh.py`. - [x] Relevant tests pass locally - [x] Relevant lint / type checks pass locally - [ ] User-facing docs or screenshots are updated when needed ## Risk - [x] Security impact considered - [x] Backward compatibility considered - [x] Rollback path is clear for risky changes User-visible change: `raven onboard` no longer asks for a Raven-Design key or recommends a model for it; an existing `DESIGN_API_KEY` line in `.env` is left in place and stays unread, as before this change. `product_state` is unchanged, so the roster still lists Raven-Design; only the wizard's tick now follows whether the host can lend a key. Rollback is a revert of the squash commit. ## Related Issues Fixes EverMind-AI#12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Reverts #9 (merge commit b88ea17), which restructured the EverOS-backed memory subsystem (native short-term / EverOS long-term) and changed the consolidation trigger from per-turn to threshold + nightly.
This is a clean inverse of that merge: 12 files, +39 -498, restoring the prior per-turn
_dispatch_backend_storepath and the original# Memoryrecall / consolidator behavior. No history rewrite.Type of change
Related issues (if there is)
Checklists
Development