Skip to content

fix: stop logging full git config (credential leak) - #758

Merged
EndBug merged 1 commit into
mainfrom
cursor/be53a3a5
Aug 8, 2026
Merged

EndBug merged 1 commit into
mainfrom
cursor/be53a3a5

Conversation

@EndBug

@EndBug EndBug commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • Stop dumping the full merged git.listConfig().all to stdout via core.debug(), which could include actions/checkout's base64 GITHUB_TOKEN in http.*.extraheader.
  • When step debug is enabled, log only an allowlisted identity snapshot (user/author/committer name and email).
  • Add unit tests covering that credential-bearing keys are never included; rebuild lib/.

Test plan

  • npm test (unit tests + lint)
  • npm run build
  • Confirm a normal commit run no longer emits extraheader / AUTHORIZATION basic in stdout without RUNNER_DEBUG
  • With ACTIONS_STEP_DEBUG=true, confirm only identity keys appear in the debug log

Made with Cursor

Avoid dumping listConfig().all via core.debug so checkout extraheader tokens are never written to action logs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 8, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@EndBug, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 407549fe-4b2e-4189-810c-1657e3e202e2

📥 Commits

Reviewing files that changed from the base of the PR and between c38a33b and 966e8f7.

📒 Files selected for processing (4)
  • lib/index.js
  • src/main.ts
  • src/util.ts
  • test/util.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EndBug
EndBug marked this pull request as ready for review August 8, 2026 21:08
@EndBug
EndBug requested a lite review from Copilot August 8, 2026 21:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents accidental credential leakage in GitHub Actions debug logs by removing the debug dump of the full merged git config (which can include http.*.extraheader and token-bearing remote URLs) and replacing it with a narrowly allowlisted “identity-only” snapshot.

Changes:

  • Replace full git.listConfig().all debug logging with allowlisted identity-only logging gated behind step debug.
  • Introduce pickGitIdentityConfig() utility to select only safe identity keys (user/author/committer name/email).
  • Add unit tests ensuring credential-bearing keys are never included; rebuild the bundled lib/ output.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
src/main.ts Stops dumping full git config; logs only allowlisted identity keys when debug is enabled.
src/util.ts Adds pickGitIdentityConfig() and the allowlisted identity key set used for safe logging.
test/util.test.ts Adds unit tests validating only identity keys are retained and credential keys are excluded.
lib/index.js Updates compiled/bundled output to reflect the new safe debug logging behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@EndBug
EndBug merged commit 0971289 into main Aug 8, 2026
12 checks passed
@EndBug
EndBug deleted the cursor/be53a3a5 branch August 8, 2026 21:16
kodiakhq Bot pushed a commit to pdylanross/fatigue that referenced this pull request Aug 12, 2026
Bumps EndBug/add-and-commit from 10 to 11.

Release notes
Sourced from EndBug/add-and-commit's releases.

v11.0.0
What's Changed

chore(deps): bump picomatch by @​dependabot[bot] in EndBug/add-and-commit#724
chore(deps-dev): bump handlebars from 4.7.8 to 4.7.9 by @​dependabot[bot] in EndBug/add-and-commit#725
chore(deps): bump lodash from 4.17.23 to 4.18.1 by @​dependabot[bot] in EndBug/add-and-commit#728
chore(deps-dev): bump ts-jest from 29.4.6 to 29.4.9 by @​dependabot[bot] in EndBug/add-and-commit#727
chore(deps): bump @​actions/github from 9.0.0 to 9.1.0 by @​dependabot[bot] in EndBug/add-and-commit#729
chore(deps): bump @​actions/github from 9.1.0 to 9.1.1 by @​dependabot[bot] in EndBug/add-and-commit#732
chore(deps): bump @​actions/core from 3.0.0 to 3.0.1 by @​dependabot[bot] in EndBug/add-and-commit#733
ci(deps): bump actions/dependency-review-action from 4 to 5 by @​dependabot[bot] in EndBug/add-and-commit#734
chore(deps-dev): bump ts-jest from 29.4.9 to 29.4.11 by @​dependabot[bot] in EndBug/add-and-commit#736
chore(deps-dev): bump jest from 30.3.0 to 30.4.2 by @​dependabot[bot] in EndBug/add-and-commit#735
chore(deps-dev): bump eslint-plugin-prettier from 5.5.5 to 5.5.6 by @​dependabot[bot] in EndBug/add-and-commit#738
chore(deps): bump js-yaml from 4.1.1 to 4.2.0 by @​dependabot[bot] in EndBug/add-and-commit#739
ci(deps): bump actions/checkout from 6 to 7 by @​dependabot[bot] in EndBug/add-and-commit#741
chore(deps): bump undici from 6.24.1 to 6.27.0 by @​dependabot[bot] in EndBug/add-and-commit#744
ci(deps): bump actions/setup-node from 6 to 7 by @​dependabot[bot] in EndBug/add-and-commit#749
chore(deps-dev): bump @​vercel/ncc from 0.38.4 to 0.44.1 by @​dependabot[bot] in EndBug/add-and-commit#746
chore(deps): bump js-yaml from 4.2.0 to 5.2.1 by @​dependabot[bot] in EndBug/add-and-commit#747
chore(deps-dev): bump ts-jest from 29.4.11 to 29.4.12 by @​dependabot[bot] in EndBug/add-and-commit#750
chore(deps): bump js-yaml from 5.2.1 to 5.2.2 by @​dependabot[bot] in EndBug/add-and-commit#751
chore(deps): bump undici from 6.27.0 to 6.28.0 by @​dependabot[bot] in EndBug/add-and-commit#753
fix: reject remote-helper git flags that enable RCE by @​EndBug in EndBug/add-and-commit#754
fix: prevent git option injection via new_branch by @​EndBug in EndBug/add-and-commit#755
fix: verify committed lib/ matches source in CI by @​EndBug in EndBug/add-and-commit#756
fix: stop logging full git config (credential leak) by @​EndBug in EndBug/add-and-commit#758
fix: reject -F/--file git args that can exfiltrate runner files by @​EndBug in EndBug/add-and-commit#759
fix: reject unmatched quotes in matchGitArgs to prevent flag injection by @​EndBug in EndBug/add-and-commit#760
fix: refuse unexpected gitlinks staged by git add by @​EndBug in EndBug/add-and-commit#761
fix: do not report committed=true for empty commit SHA by @​EndBug in EndBug/add-and-commit#757
ci: pin actions-tagger and restrict release workflow permissions by @​EndBug in EndBug/add-and-commit#762
fix: neutralize bidi and control chars in action logs by @​EndBug in EndBug/add-and-commit#763

Full Changelog: EndBug/add-and-commit@v10.0.0...v11.0.0



Commits

645ecc0 11.0.0
06e788f fix: neutralize bidi and control chars in action logs (#763)
68ec86a ci: pin actions-tagger and restrict release workflow permissions (#762)
f1bb0cc fix: do not report committed=true for empty commit SHA (#757)
ebc24bf fix: refuse unexpected gitlinks staged by git add (#761)
75038f8 fix: reject unmatched quotes in matchGitArgs to prevent flag injection (#760)
d07c930 fix: reject -F/--file git args that can exfiltrate runner files (#759)
0971289 fix: stop logging full git config (credential leak) (#758)
c38a33b fix: verify committed lib/ matches source in CI (#756)
b4a0134 fix: prevent git option injection via new_branch (#755)
Additional commits viewable in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants