ELIP100 implementation - #180
Closed
RCasatta wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Note there is also this PR on the ELIP100 ElementsProject/ELIPs#6 |
Collaborator
Author
|
I am opening a new one if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/ElementsProject/ELIPs/blob/main/elip-0100.mediawiki
very much draft, I recon if we want to support it before we need to change
ProprietaryTypeto be aVarIntor a newtype instead of au8.According to de ELIP the subtype should be
0x0100but since it's considered a VarInt it becomes0xfd0100