Deterministic Descriptor Blinding Keys ELIP - #8
Merged
apoelstra merged 1 commit intoJan 15, 2024
Merged
Conversation
RCasatta
reviewed
Nov 8, 2023
RCasatta
reviewed
Nov 8, 2023
LeoComandini
force-pushed
the
2023-11-deterministic-blinding-key
branch
from
November 17, 2023 14:21
0a275cc to
abae81a
Compare
LeoComandini
force-pushed
the
2023-11-deterministic-blinding-key
branch
4 times, most recently
from
November 18, 2023 21:09
e1ad3af to
1103a13
Compare
jgriffiths
reviewed
Nov 20, 2023
LeoComandini
force-pushed
the
2023-11-deterministic-blinding-key
branch
3 times, most recently
from
November 23, 2023 07:57
0b07531 to
a0fab33
Compare
LeoComandini
changed the title
LeoComandini
force-pushed
the
2023-11-deterministic-blinding-key
branch
from
November 23, 2023 09:01
a0fab33 to
f18dffb
Compare
jgriffiths
reviewed
Nov 23, 2023
jgriffiths
reviewed
Nov 23, 2023
jgriffiths
reviewed
Nov 23, 2023
LeoComandini
force-pushed
the
2023-11-deterministic-blinding-key
branch
2 times, most recently
from
November 24, 2023 06:14
aff098d to
c52c80d
Compare
Collaborator
|
LGTM thanks, ack. |
apoelstra
reviewed
Nov 27, 2023
apoelstra
reviewed
Nov 27, 2023
Member
|
c52c80d lgtm. Just two minor comments. |
Member
|
Assigned ELIP 151. Having said this, my original vision was that people would achieve this by choosing otherwise-unused BIP32 paths and then combining their keys using |
Collaborator
Author
|
Addressed review comments and used assigned elip number in the last commit, will squash it later |
Member
|
Looks great! |
Collaborator
Author
|
will squash and update after #9 is merged (or abandoned/nacked) |
LeoComandini
force-pushed
the
2023-11-deterministic-blinding-key
branch
from
December 21, 2023 11:42
7a57995 to
59dae9f
Compare
Collaborator
Author
|
Rebased, updated and squashed. Also updated reference impl ElementsProject/elements-miniscript#61 |
apoelstra
approved these changes
Dec 22, 2023
apoelstra
added a commit
to ElementsProject/elements-miniscript
that referenced
this pull request
Jan 9, 2024
34005bc Add ELIP-151 module (Leonardo Comandini) Pull request description: Reference implementation for ElementsProject/ELIPs#8 ACKs for top commit: apoelstra: ACK 34005bc Tree-SHA512: 8f376d246f6240820606dc555401e94bfadc92614644c3eeafde57674bc62b8e20cde766632540325ceb4e35e51a7006d9bdf175e5b9eb3948a5f5fe56f137eb
Collaborator
Author
|
@apoelstra do we need more work/review on this? or it can be merged? related ref impl was merged ElementsProject/elements-miniscript#61 |
Member
|
I think we can merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.