Repository navigation
♻️ Migrate CLI print methods to single module #601
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershacktoberfestIssues for the HacktoberfestIssues for the Hacktoberfesthelp wantedExtra attention is neededExtra attention is needed
Description
Activity
- addedenhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is neededgood first issueGood for newcomersGood for newcomershacktoberfestIssues for the HacktoberfestIssues for the Hacktoberfest
on Apr 19, 2022 Hello my name is Antonio and I would like to contribute to this issue along with my two peers, Pedro and Justice.
Hey, I'm Pedro Rangel, and I will be part of the team.
Hello my name is Justice and I would like to help contribute to this issue along with Antonio, and Pedro.
welcome @JKnight777 @CodingForFun-coder and @Alopezjr2002 welcome aboard! Please have at it and use this issue for any questions and comments. I'll also send you invites to the Democracy Forward slack
- added 5 commits that reference this issue
on Jul 21, 2022
Metadata
Metadata
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershacktoberfestIssues for the HacktoberfestIssues for the Hacktoberfesthelp wantedExtra attention is neededExtra attention is needed
Is there an existing issue for this?
Suggestion
To improve the CLI and be a bit more pythonic, migrate the common click to echo to a more aptly named module. Ideally, this should contain the references to
click.echoto a single module, but the closest to this is best.Possible Implementation
Create a
print_utils.pyfile in theelectionguard_clito be used for all print functionality. These should all be methods and no classes should be necessary. This should allow the deletion ofe2estepbase.pySuggested items to migrate:
https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/input_retrieval_step.py#L42
https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/e2e_step_base.py#L14
https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/e2e_step_base.py#L19
https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/print_results_step.py#L13
Anything else?
No response