Skip to content

♻️ Migrate CLI print methods to single module #601

Description

@keithrfung

Is there an existing issue for this?

  • I have searched the existing issues

Suggestion

To improve the CLI and be a bit more pythonic, migrate the common click to echo to a more aptly named module. Ideally, this should contain the references to click.echo to a single module, but the closest to this is best.

Possible Implementation

Create a print_utils.py file in the electionguard_cli to be used for all print functionality. These should all be methods and no classes should be necessary. This should allow the deletion of e2estepbase.py

Suggested items to migrate:
https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/input_retrieval_step.py#L42
https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/e2e_step_base.py#L14
https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/e2e_step_base.py#L19

https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/print_results_step.py#L13

Anything else?

No response

Activity

  1. Alopezjr2002 commented on Jul 6, 2022

    @Alopezjr2002

    Hello my name is Antonio and I would like to contribute to this issue along with my two peers, Pedro and Justice.

  2. CodingForFun-coder commented on Jul 6, 2022

    @CodingForFun-coder

    Hey, I'm Pedro Rangel, and I will be part of the team.

  3. JKnight777 commented on Jul 6, 2022

    @JKnight777

    Hello my name is Justice and I would like to help contribute to this issue along with Antonio, and Pedro.

  4. rc-ms commented on Jul 6, 2022

    @rc-ms
    Contributor

    welcome @JKnight777 @CodingForFun-coder and @Alopezjr2002 welcome aboard! Please have at it and use this issue for any questions and comments. I'll also send you invites to the Democracy Forward slack

  5. added 5 commits that reference this issue on Jul 21, 2022
    132ea76
    67fea70
    46a9639
    35e900f
    08f673c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions