Expose terminal state through Stdio - #7090
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b22ed7f The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Important
This PR adds new public API surface to Stdio but does not include a changeset, which is required for exported API changes in this repo.
Reviewed changes
- Added
stdinIsTerminalandstdoutIsTerminaleffects to the publicStdioservice interface and made them optional inStdio.makewithfalsedefaults. - Implemented lazy terminal detection for Node/Bun (
process.std*.isTTY) and Deno (Deno.std*.isTerminal()). - Added tests for defaults, overrides, and lazy runtime evaluation across
effect,platform-node-shared, andplatform-deno.
⚠️ Missing changeset
Exported type/API changes require a changeset in .changeset/. Add one covering effect, @effect/platform-node-shared, and @effect/platform-deno (or the relevant fixed group) describing the new terminal-state effects.
Technical details
# Missing changeset for Stdio terminal state
## Affected sites
- `packages/effect/src/Stdio.ts` — new `stdinIsTerminal`/`stdoutIsTerminal` interface fields
- `packages/platform-node-shared/src/NodeStdio.ts` — Node/Bun implementation
- `packages/platform-deno/src/DenoStdio.ts` — Deno implementation
## Required outcome
- A changeset is added under `.changeset/` (existing pre-release changesets live in `.changeset/pre/`) describing the new public API and bumping the affected packages.
- The changeset follows the format used by recent pre-release changesets such as `.changeset/pre/eff-143-deno-stdio.md`.
## Suggested approach (optional)
Example `.changeset/pre/eff-532-stdio-terminal.md`:
```md
---
"effect": patch
"@effect/platform-node-shared": patch
"@effect/platform-deno": patch
---
Expose `stdinIsTerminal` and `stdoutIsTerminal` effects through the `Stdio` service.
```@v0 or keep the SHA fresh with Dependabot ｜ Fix it ➔ ｜ View workflow run ｜ Using Kimi K2 (free via Pullfrog for OSS) ｜ 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Added
.changeset/eff-532-stdio-terminal.mdcoveringeffect,@effect/platform-node-shared, and@effect/platform-denoat patch level, addressing the missing-changeset feedback from the prior review.
@v0 or keep the SHA fresh with Dependabot ｜ View workflow run ｜ Using Kimi K2 (free via Pullfrog for OSS) ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StdioserviceStdio.makedefaults and deterministiclayerTestoverridesValidation
pnpm checkpnpm lintpnpm vitest run --project effect packages/effect/test/Stdio.test.tspnpm vitest run --project @effect/platform-node-shareddeno task test run --project @effect/platform-denoCloses EFF-532