Update scikit-learn to v1.4 - #766
Merged
Merged
Conversation
- Remove deprecated `scale` parameter from seaborn calls. - Add explicit `palette` call when plotting time curve since that's now required. - Use `matplotlib.category` msg filter to filter out unnecessary msgs.
- `needs_proba` and `needs_threshold` arguments for `make_scorer()` are deprecated in favor of `response_method`. - `LinearSVC` and `LinearSVR` now need to have `dual` explicitly set to "auto". - `AdaBoostClassifier` now needs to have algorithm` set to "SAMME". - Update custom metrics documentation. - Update tests and test data.
- Sklearn 1.4 drops support for python 3.8 and 3.9.
desilinguist
requested review from
Frost45,
damien2012eng,
mulhod and
tamarl08
February 16, 2024 14:30
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
==========================================
- Coverage 95.44% 95.43% -0.02%
==========================================
Files 30 30
Lines 3688 3701 +13
==========================================
+ Hits 3520 3532 +12
- Misses 168 169 +1 ☔ View full report in Codecov by Sentry. |
tamarl08
approved these changes
Feb 16, 2024
mulhod
reviewed
Feb 20, 2024
mulhod
approved these changes
Feb 20, 2024
This was referenced Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requirements.txt.test_output.matplotlibmessages.matplotlibmessages.scaleparameter from seaborn calls.palettecall when plotting time curve since that's now required.matplotlib.categorymsg filter to filter out unnecessary msgs.needs_probaandneeds_thresholdarguments formake_scorer()are deprecated in favor ofresponse_method.LinearSVCandLinearSVRnow need to havedualexplicitly set to "auto".AdaBoostClassifiernow needs to have algorithm` set to "SAMME".