Add BaggingClassifier and BaggingRegressor support - #742
Merged
Conversation
- It turns out that there's a long standing bug in SKLL where using meta-estimators like AdaBoost* that use a base estimator are unable to be used with `run_experiment` since their base estimator prevents the model parameters dictionary from being serialized to disk. Added code that replaces the base estimator object with a string before serializing. - Existing tests did not cover this scenario since they used those meta-estimators via the API and not via a configuration file. Added new tests that covered this scenario.
desilinguist
requested review from
Frost45,
damien2012eng,
dblandan,
mulhod and
tamarl08
June 20, 2023 14:23
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #742 +/- ##
=======================================
Coverage 95.19% 95.19%
=======================================
Files 29 29
Lines 3535 3538 +3
=======================================
+ Hits 3365 3368 +3
Misses 170 170
☔ View full report in Codecov by Sentry. |
Frost45
reviewed
Jun 20, 2023
Frost45
approved these changes
Jun 20, 2023
Frost45
left a comment
Frost45
left a comment
Contributor
There was a problem hiding this comment.
Tested it out with Titanic! Everything works as expected 🎉
Co-authored-by: Sanjna Kashyap <20379363+Frost45@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_experimentsince their base estimator prevents the model parameters dictionary from being serialized to disk. Added code that replaces the base estimator object with a string before serializing.BaggingClassifierandBaggingRegressorEasiest way to review is to try out the new learners (along with different
estimatorfixed parameter values) in the California and Titanic examples.This PR closes #614.