Skip to content

Add type hints to skll.experiments module - #732

Merged
desilinguist merged 4 commits into
mainfrom
561-type-hints-experiments-3
May 24, 2023
Merged

Add type hints to skll.experiments module#732
desilinguist merged 4 commits into
mainfrom
561-type-hints-experiments-3

Conversation

@desilinguist

Copy link
Copy Markdown
Collaborator
  • Add new custom types to skll.types.
  • Fix buggy type hint in skll.config.utils.
  • Add type hints to all files under skll.experiments.

Comment thread skll/config/utils.py Outdated
@codecov

codecov Bot commented May 24, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 98.52% and project coverage change: +0.01 🎉

Comparison is base (a3f45d5) 95.24% compared to head (c17da1e) 95.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
+ Coverage   95.24%   95.26%   +0.01%     
==========================================
  Files          29       29              
  Lines        3449     3461      +12     
==========================================
+ Hits         3285     3297      +12     
  Misses        164      164              
Impacted Files Coverage Δ
skll/config/utils.py 96.15% <80.00%> (-0.08%) ⬇️
skll/experiments/__init__.py 94.63% <100.00%> (ø)
skll/experiments/input.py 100.00% <100.00%> (ø)
skll/experiments/output.py 97.44% <100.00%> (+0.02%) ⬆️
skll/experiments/utils.py 93.38% <100.00%> (+0.22%) ⬆️
skll/types.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread skll/experiments/__init__.py Outdated
Comment thread skll/experiments/output.py
Comment thread skll/experiments/output.py Outdated
Comment thread skll/experiments/utils.py
@desilinguist
desilinguist merged commit f8c3da8 into main May 24, 2023
@delete-merged-branch
delete-merged-branch Bot deleted the 561-type-hints-experiments-3 branch May 24, 2023 20:04
@desilinguist

Copy link
Copy Markdown
Collaborator Author

This is part of #561.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants