Use 5 folds for grid search - #667
Merged
Merged
Conversation
- Update `grid_search_folds` documentation - Also change default value of `MAX_SKLL_CONCURRENT_PROCESSES` to 5.
Otherwise tests take too long. Note that the the config parsing tests in `test_input.py` were correctly modified to check that the default value for grid search folds is 5.
Codecov Report
@@ Coverage Diff @@
## main #667 +/- ##
=======================================
Coverage 96.76% 96.76%
=======================================
Files 63 63
Lines 9077 9077
=======================================
Hits 8783 8783
Misses 294 294
Continue to review full report at Codecov.
|
Collaborator
Author
|
@mulhod it'd be really great if you could test this with gridmap as well. Thanks! |
desilinguist
marked this pull request as ready for review
February 23, 2021 14:10
aoifecahill
approved these changes
Feb 23, 2021
aoifecahill
left a comment
aoifecahill
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks!
mulhod
approved these changes
Feb 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #487.
See issue for motivation to change the default number of folds for grid search cross-validation. One by-product of the change is that experiments will certainly take longer to run but they are likely to be more reliable.
Changes:
grid_search_foldsdocumentationMAX_SKLL_CONCURRENT_PROCESSESto 5.test_input.pywere correctly modified to check that the default value for grid search folds is 5.