Skip to content

Update scikit-learn to 0.22.2 - #595

Merged
desilinguist merged 18 commits into
masterfrom
update-scikit-learn
Mar 12, 2020
Merged

Update scikit-learn to 0.22.2#595
desilinguist merged 18 commits into
masterfrom
update-scikit-learn

Conversation

@desilinguist

Copy link
Copy Markdown
Collaborator

This PR:

  • updates scikit-learn from 0.21.3 to 0.22.2
  • updates test data due to this update
  • updates import statements because of scikit-learn's API refactoring
  • fixes a bug in logutils.py.

Note: The conda and PyPI packages for 0.22.2 have a strange name this time (0.22.2.post1). This is most likely because they needed to fix something after they had already uploaded 0.22.2 to PyPI which does not allow re-uploading with the same version number.

@pep8speaks

pep8speaks commented Mar 10, 2020

Copy link
Copy Markdown

Hello @desilinguist! Thanks for updating this PR.

Line 318:101: E501 line too long (105 > 100 characters)

Comment last updated at 2020-03-10 23:20:37 UTC

@codecov

codecov Bot commented Mar 10, 2020

Copy link
Copy Markdown

Codecov Report

Merging #595 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #595   +/-   ##
=======================================
  Coverage   95.05%   95.06%           
=======================================
  Files          20       20           
  Lines        2974     2977    +3     
=======================================
+ Hits         2827     2830    +3     
  Misses        147      147           
Impacted Files Coverage Δ
skll/learner.py 96.12% <100.00%> (+<0.01%) ⬆️
skll/logutils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70cd583...34b00de. Read the comment docs.

@desilinguist

Copy link
Copy Markdown
Collaborator Author

@aoifecahill @bndgyawali @AVajpayeeJr @ananyaganesh this PR is now ready for review.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any change in the data or experiments in the tests. In a few cases I see a bigger difference, so wondering why it is happening.

Comment thread tests/test_cv.py
Comment thread examples/Tutorial.ipynb
@desilinguist

Copy link
Copy Markdown
Collaborator Author

@bndgyawali there are a lot of bug fixes and changes in scikit-learn so all of the changes in the numbers are due to that.

Comment thread skll/learner.py
@desilinguist desilinguist linked an issue Mar 11, 2020 that may be closed by this pull request
@desilinguist
desilinguist merged commit b1a5e14 into master Mar 12, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the update-scikit-learn branch March 12, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update scikit-learn to 0.22.2

3 participants