Repository navigation
Make v5 allow PHP 8 #17
Description
Hey, I recently stumbled across this and project and I am using it and loving it, thanks for the great work!
I am using it in conjunction with PHP 8 and thecodingmachine/graphqlite.
graphqlite has a requirement for webonyx/graphql-php ^v0.13.4 (https://github.com/thecodingmachine/graphqlite/blob/master/composer.json#L14).
graphql-upload v6 requires webonyx/graphql-php ^14.
Therefore currently I can only use graphql-upload v5 together with graphqlite. But graqhl-upload v5 does not support PHP 8, so it is impossible to use graphql-php in my setup. That is why I created a fork and tagged a 5.0.1 which allows PHP 8.
This is all I had to do: svnldwg-forks@57b5d83
It works, but I would love to get rid of my fork and just use the original project. Could you allow PHP 8 for v5?
Activity
PowerKiKi commentedon Mar 4, 2021
I'm surprised to learn that you use both libraries together. I'm not familiar with
thecodingmachine/graphqlite, but was under the impression that it would be more of a replacement toecodev/graphql-upload, rather than a complement.But anyway, unfortunately we don't support past versions. And even though this particular change seems small, I am not willing to introduce a precedent by accepting this change.
Instead I would suggest to push for an update of
thecodingmachine/graphqlite. It seems they are willing to do it and would accept help for it. There is also an opened PR for it: thecodingmachine/graphqlite#327svnldwg commentedon Mar 4, 2021
Thanks for your reply, I understand.
Yes,
thecodingmachine/graphqliterelies on your package for file uploads. It is documented here: https://graphqlite.thecodingmachine.io/docs/file-uploadsPowerKiKi commentedon Mar 5, 2021
Oh my bad, I thought we were talking about
ecodev/graphql-doctrine🙄 , which is a replacement tothecodingmachine/graphqlite. Butecodev/graphql-uploadtotally make sense to be used withthecodingmachine/graphqlite.