!feat: use fetch instead of superagent (closes #552) - #555
Open
Justin Hammond (Justintime50) wants to merge 4 commits into
Open
!feat: use fetch instead of superagent (closes #552)#555Justin Hammond (Justintime50) wants to merge 4 commits into
Justin Hammond (Justintime50) wants to merge 4 commits into
Conversation
Justin Hammond (Justintime50)
marked this pull request as ready for review
July 31, 2026 17:06
1 task
Jeremy Hinegardner (copiousfreetime)
approved these changes
Aug 3, 2026
Jeremy Hinegardner (copiousfreetime)
left a comment
Jeremy Hinegardner (copiousfreetime)
left a comment
There was a problem hiding this comment.
Just a few non-blocking clarifications.
| - `superagent` is no longer a runtime dependency. | ||
| - Node 18+ is now required (built-in `fetch`). | ||
| - `superagentMiddleware` has been removed and replaced by `httpMiddleware`. | ||
| - `fetchClient` has been renamed to `httpClient`. |
There was a problem hiding this comment.
Should this be agent has been renamed to httpClient?
| this.timeout = timeout || EasyPostClient.DEFAULT_TIMEOUT; | ||
| this.baseUrl = baseUrl || EasyPostClient.DEFAULT_BASE_URL; | ||
| this.agent = superagent; | ||
| this.httpClient = |
There was a problem hiding this comment.
This is the rename that you're talking about in the Upgrade Guide right ?
|
|
||
| expect(address.verifications.delivery.errors[0].message).to.equal('Address not found'); | ||
| expect(address.verifications.zip4.errors[0].message).to.equal('Address not found'); | ||
| return client.Address.createAndVerify(addressData).catch((err) => |
There was a problem hiding this comment.
This test changes what it tests -- its now checking that there is an exception on create and Verify instead of the address being a valid object, and the errors are in that object. Is this a behavior change in the api?
| @@ -32,32 +32,6 @@ describe('CarrierAccount Service', function () { | |||
| await client.CarrierAccount.delete(carrierAccount.id); | |||
| }); | |||
|
|
|||
| it('creates a carrier account with a custom workflow', async function () { | |||
There was a problem hiding this comment.
Is there a reason for this test removal?
| - Breaking: HTTP transport migrated from `superagent` to fetch-compatible transport | ||
| - `superagent` runtime dependency removed | ||
| - Breaking: `superagentMiddleware` renamed to `httpMiddleware` | ||
| - Breaking: `fetchClient` renamed to `httpClient` |
There was a problem hiding this comment.
Should be agent renamed to httpClient ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fetchis only in Node 18+superagentto fetch-compatible transportsuperagentruntime dependency removedsuperagentMiddlewarerenamed tohttpMiddlewarefetchClientrenamed tohttpClientmakeApiCallnow acceptsdelete(thedelalias was removed)requestMiddlewarecompatibility preserved using a fetch-era compatibility request objectUser-Agentretains structured runtime metadata fields (Nodejs/,OS/,OSVersion/,OSArch/) via runtime-safe detectionCloses #552
Testing
Pull Request Type
Please select the option(s) that are relevant to this PR.