Skip to content

Fix quoting in check-compset-aliases.sh and paths in check-testlists.yml - #4247

Open
Santoshkumarpuppala wants to merge 1 commit into
ESCOMP:b4b-devfrom
Santoshkumarpuppala:fix-4214-ci-gates
Open

Santoshkumarpuppala wants to merge 1 commit into
ESCOMP:b4b-devfrom
Santoshkumarpuppala:fix-4214-ci-gates

Conversation

@Santoshkumarpuppala

Copy link
Copy Markdown
Contributor

Description of changes

check-compset-aliases.sh: since 90c332134 the patterns on lines 25 and 44 are wrapped in literal quotes (\"$ALIAS\" inside $( )), so the --fixed-strings greps match nothing and the check passes whatever is in config_compsets.xml. This drops the backslashes and restores --invert-match on the last grep of line 44, which the same commit removed and the quoting hid.

check-testlists.yml: the path filters name files that don't exist (add_supertestlists, and cime_config/ without testdefs/), so the job has never run, and its cd target is missing the s. This corrects both and adds the workflow file to its own paths so this PR runs it.

Both workflows trigger on this PR, so their runs here are the check against today's b4b-dev. If the compset check fails, it stops at the first failing check and lists that check's compsets.

Specific notes

Contributors other than yourself, if any:

  • None

CTSM issues resolved or otherwise addressed, if any:

Any user interface changes (namelist or namelist defaults changes)?
None. CI scripts only.

Testing planned or performed, if any:

  • The 2ebc042 results with the real query_config are in check-compset-aliases.sh doesn't seem to be working correctly #4214: fixing only the quotes gives false positives; with --invert-match restored, the unchanged tree passes and both broken examples fail.
  • bash -n on the edited script and a YAML parse of the edited workflow, both clean.
  • Neither script run locally on this branch; the two workflow runs on this PR are the test.

Requirements before merge:

  • I have followed the CTSM contribution guidelines.
  • The code in this PR branch builds with no errors. Not applicable: CI scripts only; CTSM was not built.
  • The code in this PR branch runs with no errors. Not applicable: CI scripts only. Briefly describe tested configuration(s): see Testing above.
  • This either (a) does not change answers, (b) it only changes answers at roundoff level, or (c) I have performed a scientific evaluation of the answer changes. Which?: (a)
  • I have reviewed relevant parts of the CLM documentation Tech Note or User's Guide to determine if anything needs to be changed or added. If it does, describe: The Tech Note and User's Guide don't cover these two workflows.
  • This PR either (a) does not create a need to update the documentation or (b) includes required documentation updates (see guidelines for contributing documentation). Which?: (a)

check-compset-aliases.sh wrapped each grep pattern in literal double
quotes (\"$ALIAS\" inside $(...)), so the --fixed-strings greps matched
nothing and the check passed any config_compsets.xml. 90c3321 also
dropped --invert-match from the last grep of check_missing_alias_matches,
which the quoting hid.

check-testlists.yml filtered on paths that do not exist
(add_supertestlists, cime_config/ without testdefs/), so the job never
ran, and cd'd into cime_config/testdef. Fix the paths and the directory,
and add the workflow file to its own paths.

Fixes ESCOMP#4214
@ekluzek
ekluzek self-requested a review October 8, 2026 16:25
@samsrabin samsrabin added the b4b bit-for-bit label Oct 9, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants