Repository navigation
Fix quoting in check-compset-aliases.sh and paths in check-testlists.yml - #4247
Open
Santoshkumarpuppala wants to merge 1 commit into
Open
Santoshkumarpuppala wants to merge 1 commit into
Santoshkumarpuppala wants to merge 1 commit into
Conversation
check-compset-aliases.sh wrapped each grep pattern in literal double quotes (\"$ALIAS\" inside $(...)), so the --fixed-strings greps matched nothing and the check passed any config_compsets.xml. 90c3321 also dropped --invert-match from the last grep of check_missing_alias_matches, which the quoting hid. check-testlists.yml filtered on paths that do not exist (add_supertestlists, cime_config/ without testdefs/), so the job never ran, and cd'd into cime_config/testdef. Fix the paths and the directory, and add the workflow file to its own paths. Fixes ESCOMP#4214
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
check-compset-aliases.sh: since90c332134the patterns on lines 25 and 44 are wrapped in literal quotes (\"$ALIAS\"inside$( )), so the--fixed-stringsgreps match nothing and the check passes whatever is inconfig_compsets.xml. This drops the backslashes and restores--invert-matchon the last grep of line 44, which the same commit removed and the quoting hid.check-testlists.yml: the path filters name files that don't exist (add_supertestlists, andcime_config/withouttestdefs/), so the job has never run, and itscdtarget is missing thes. This corrects both and adds the workflow file to its own paths so this PR runs it.Both workflows trigger on this PR, so their runs here are the check against today's
b4b-dev. If the compset check fails, it stops at the first failing check and lists that check's compsets.Specific notes
Contributors other than yourself, if any:
CTSM issues resolved or otherwise addressed, if any:
Any user interface changes (namelist or namelist defaults changes)?
None. CI scripts only.
Testing planned or performed, if any:
2ebc042results with the realquery_configare in check-compset-aliases.sh doesn't seem to be working correctly #4214: fixing only the quotes gives false positives; with--invert-matchrestored, the unchanged tree passes and both broken examples fail.bash -non the edited script and a YAML parse of the edited workflow, both clean.Requirements before merge: