Repository navigation
Finalize ESMF objects for components - #453
Open
danrosen25 wants to merge 1 commit into
Open
danrosen25 wants to merge 1 commit into
danrosen25 wants to merge 1 commit into
Conversation
* adds helper function for ESMF cleanup to dshr_strdata_mod * adds helper functions for ESMF cleanup to dshr_mod * finalize strdata: destroy ESMF objs in each pstrm for each cmp * finalize mesh: destroy ESMF mesh(es) for each cmp * finalize alarms: destroy alarms associated with each cmp clock * destroy temporary ESMF objects in datm_get_adjustment_factors * destroy temporary ESMF objects in dglc_datamode_noevolve_advance * destroy temporary ESMF objects in dshr_set_modelmask * destroy temporary ESMF objects in shr_strdata_readstrm * destroy temporary ESMF objects in shr_stream_init_from_esmfconfig
mvertens
approved these changes
Oct 13, 2026
mvertens
left a comment
mvertens
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for taking this on and doing a really clean implementation. This all looks good to me.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR addresses memory leaks caused by creating ESMF objects that are not destroyed.
Specific notes
Contributors other than yourself, if any:
@billsacks @ekluzek
CDEPS Issues Fixed (include github issue #):
Partially addresses issue 261
Are there dependencies on other component PRs (if so list): No
Are changes expected to change answers (bfb, different to roundoff, more substantial): No
Any User Interface Changes (namelist or namelist defaults changes): No
Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
Tested using cime
--xml-category aux_cdeps20261009_115334_g3s4bt: 37 tests
Hashes used for testing:
CESM: ba0a56365ae08a89cf8f68eda69af231fa67d49c
CDEPS: c918615