Skip to content

No longer need to allow for C/E at end of time period - changes for DOCN - #449

Merged
billsacks merged 1 commit into
ESCOMP:mainfrom
billsacks:more_ce_removal
Oct 1, 2026
Merged

billsacks merged 1 commit into
ESCOMP:mainfrom
billsacks:more_ce_removal

Conversation

@billsacks

Copy link
Copy Markdown
Member

Description of changes

With the changes in ESCOMP/CESM#407 and ESCOMP/CAM#1584, we no longer need to allow for C/E at the end of the time period.

Related to #413; I somehow missed these changes there

Specific notes

Contributors other than yourself, if any: none

CDEPS Issues Fixed (include github issue #): none

Are there dependencies on other component PRs (if so list):

Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb

Any User Interface Changes (namelist or namelist defaults changes): none

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
(1) aux_cdeps
(2) aux_cime_baseline tests that include DOCN:

ERP_Ln9.f09_f09_mg17.F2000climo.derecho_intel.cam-outfrq9s
ERP_Ln9.f09_f09_mg17.FHIST.derecho_intel.cam-outfrq9s
ERP_Ln9.f09_f09_mg17.FHIST_BGC.derecho_intel.cam-outfrq9s
ERP_Ln9.f09_f09_mg17.F1850.derecho_intel.cam-outfrq9s
ERP_D_Ln9.f19_f19_mg17.QPC6.derecho_intel.cam-outfrq9s
ERP_D_Ln9_P64x2.f09_f09_mg17.QSC6.derecho_intel.cam-outfrq9s
ERI.TL319_t232.DTEST.derecho_intel.cice-default
ERS_D_Ld5.TL319_t232.DTEST.derecho_intel.cice-default

All tests pass and are bit-for-bit with baselines.

Hashes used for testing: cesm3_0_beta10

With the changes in ESCOMP/CESM#407 and
ESCOMP/CAM#1584, we no longer need to allow for
C/E at the end of the time period.

Related to ESCOMP#413; I somehow missed
these changes there

@mvertens mvertens left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billsacks - I suggest removing the grid specific settings since CDEPS does the interpolation and none of these resolutions are actually being used. I have removed them from a PR I am working on to bring in input4mip forcing. We should talk about that to hopefully coordinate the NorESM and ESCOMP cdeps settings.

@billsacks

Copy link
Copy Markdown
Member Author

I suggest removing the grid specific settings since CDEPS does the interpolation and none of these resolutions are actually being used. I have removed them from a PR I am working on to bring in input4mip forcing. We should talk about that to hopefully coordinate the NorESM and ESCOMP cdeps settings.

My feeling is that that is a separate change outside the scope of this PR: I'd like to keep this one limited and straightforward. I'm happy to talk to you about that removal of grid-specific settings, though I'd like to run that by someone in the CAM group who might have a better sense of that than I do.

@mvertens

mvertens commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

@billsacks - good point about the separate change. This could be a follow on PR.

@billsacks
billsacks merged commit 1ff280f into ESCOMP:main Oct 1, 2026
1 check passed
@billsacks
billsacks deleted the more_ce_removal branch October 1, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants