Repository navigation
#2606: lexical LET/LAMBDA variable scoping, balanced scope stack - #2607
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2606: Lexical scoping for LET/LAMBDA variables
Problem
A named LAMBDA with a
LETbody could bind a parameter to the value of another LAMBDA call's parameter with the same name. New scopes took their parent from the top of the shared variable storage stack, and that stack was left unbalanced. The bug showed in nested calls (Out(2, In(5))) and when calculating worksheet by worksheet.Changes
VariableStorageManagergetsBeginCompile/EndCompile/PeekLexical. Scopes created during compilation get their parent from the enclosing LET/LAMBDA or the lambda's own scope, never from leftover runtime scopes.VariableFunctionExpression.OnDispose,LambdaCalculator.Execute,EndCompile). Blind pops andClear()calls inCompileExpressionsandRpnFormula.Resetare removed.RpnFormulaExecutionrestore the stack depth on exit.LambdaNameFunction.Executereturns#VALUE!for too many arguments instead of relying on an exception.Tests
New
LambdaVariableScopeTests: issue repros, control cases and stack-balance invariants. The full test suite passes.