Remove right-wildcard targets (if possible)

[cschanaj]

This issue might take a long long long time to complete since a rewrite is not always possible.

Using a modified command from #11187 (comment)

egrep -l '<target\s+host=\s*"[^"]*\.\*"\s*/>' *.xml

• EBay.xml
• Eventim.xml Update Eventim.xml #10948
• GoogleImages.xml (e8bb995)
• GoogleMaps.xml (30ac448)
• GoogleShopping.xml (4c82624)
• Google.tld_Subdomains.xml
• GoogleVideos.xml
• Google.xml
• Live-Nation.xml (Remove wildcards from Live-Nation.xml #14255)
• Ticketmaster.xml (Update Ticketmaster related rulesets #19215)
• Wyndham.xml Spliting Wyndham.xml into Separate Rulesets #12672
• All-Inkl.xml [All-inkl] Remove right-wildcard and simplify ruleset #11054
• Bytename.xml Delete Bytename.xml #11242
• Capital-One-Connect.xml Delete Capital-One-Connect.xml #11237
• Directbox.xml [Directbox] Remove right wildcard and reactivate ruleset #11246
• EKomi.xml Rename and update eKomi.xml  #11302
• F5-mismatches.xml Update F5.com related rulesets (Right-wildcard) #12519
• Foresters.xml Simplify Foresters.xml #11205
• GlobalSign.xml Simplify GlobalSign.xml #11201
• GymGlish.xml, GymGlish-problematic.xml Update Gymglish.com.xml #11278
• HSBC.xml (does not use a right-wildcard)
• Jako-O.xml Simplify Jako-O.xml #11248
• KickNews.xml Simplify KickNews.xml #11202
• Kimberly-Clark.xml Update huggies.com.au related rulesets #11249
• Krisostomus.xml [Kriso] Remove left- and right-wildcards #11056 Simplify and default_off Krisostomus.xml #11200
• LoveFilm.xml Simplify LoveFilm.xml #11207
• Nokia.xml Re-activate and Update Nokia.xml #11285
• Nordea.xml Simplify Nordea.xml #11250
• Planet-Work.xml Simplify Planet-Work.xml #11239
• Red_Bull.xml Re-activate and Update Red_Bull.xml #11852
• Rochesterhomepage.net.xml Delete Rochesterhomepage.net.xml #11551
• SamKnows.xml Simplify SamKnows.xml #11206
• Servage.net.xml [Servage] Remove left and right wildcards #11245
• ShopStyle.xml, ShopStyle-mismatches.xml Update ShopStyle.xml (Right wildcard) #12521
• Siemens.com.xml Update Siemens.xml #11451
• SimFlight-problematic.xml Update SimFlight-problematic.xml (Right Wildcard) #12616
• STRATO.xml Simplify STRATO.xml #11279
• Thumbshots.xml [Thumbshots] Simplify ruleset #11765
• Tickengo.xml Delete Tickengo.xml #11204
• Trusted-Shops.xml Update Trusted_Shops.xml (Right wildcard) #12522
• UltraDNS.xml Simplify UltraDNS.xml #11241
• World_of_Warplanes.xml [WordOfWarPlanes] Remove right-wildcard and broken targets #11055
• World_of_Warships.xml [WordOfWarships] Remove right-wildcard and add targets #11057

[Bisaloo]

From #1327 (comment):

Yeah, I think it would be useful to run a script that does lookups for all the ICANN public suffixes to expand the right-side wildcards to the things they actually resolve to.

It's probably not necessary in many cases because the wildcard actually only covers a handful of suffixes but it may be useful for Google related rulesets for example.

https://publicsuffix.org/

[cschanaj]

I agree that using a script to expand the right wildcard is a probable approach, but popular sites like Google might own nearly all suffix for its domains. It might result in a (number of) huge ruleset with a overwhelming number of target leading to long term maintenance issue.

I will prefer to whitelist a ruleset from the rule-test if it does not cover only a handful number of the suffix.

Remark: Please be noted that the proposed changes rule-test ignore right wildcard target currently.

[Bisaloo]

The idea of removing right-sided wildcards was supported by two of the project developers. We can always ask @Hainish if he shares their views or if the EFF opinion on this has changed.

It might result in a (number of) huge ruleset with a overwhelming number of target leading to long term maintenance issue.

Don't forget that right-sided wildcards are also a hassle to maintain because they don't work with our current automated tools to disable/remove rulesets (https-everywhere-full-fetch-test and hsts-prune) and possibly with future ones as well.