Conversation
mahf708
approved these changes
Sep 22, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The env var prevents mpirun to return a non-zero exit code just b/c a race condition completely internal to MPI implementation has caused one of the rank to exit before the MPI runtime expected it to. This env var forces mpirun to allow rank to exit without waiting for ORTE to send an acknowledgement that it received their exit request (or something along that line).
For context, the error I was seeing was of this form:
As you can see, the test itself passed. I even added a print statement in eamxx's
test-launcherto print the executable rc, and it was always 0, even when MPI crapped out. So this env var is truly the right thing to do for us.