Skip to content

Filter OperationCanceled instead of TaskCanceled logs - #1671

Merged
josephdecock merged 1 commit into
mainfrom
joe/operation-canceled
Dec 11, 2024
Merged

josephdecock merged 1 commit into
mainfrom
joe/operation-canceled

Conversation

@josephdecock

Copy link
Copy Markdown
Member

When an http request is canceled, we'll get some sort of cancellation related exception. There are reports that this sometimes is raised as OperationCanceled instead of TaskCanceled, and since OperationCanceled is the base class, it is simpler to filter that instead.

What issue does this PR address?
Closes #1587

Important: Any code or remarks in your Pull Request are under the following terms:

If You provide us with any comments, bug reports, feedback, enhancements, or modifications proposed or suggested by You for the Software, such Feedback is provided on a non-confidential basis (notwithstanding any notice to the contrary You may include in any accompanying communication), and Licensor shall have the right to use such Feedback at its discretion, including, but not limited to the incorporation of such suggested changes into the Software. You hereby grant Licensor a perpetual, irrevocable, transferable, sublicensable, nonexclusive license under all rights necessary to incorporate and use your Feedback for any purpose, including to make and sell any products and services.

(see our license, section 7)

When an http request is canceled, we'll get some sort of cancellation related exception. There are reports that this sometimes is raised as OperationCanceled instead of TaskCanceled, and since OperationCanceled is the base class, it is simpler to filter that instead.
@josephdecock
josephdecock requested a review from damianh December 11, 2024 17:39
@josephdecock
josephdecock merged commit 4a1564c into main Dec 11, 2024
@josephdecock
josephdecock deleted the joe/operation-canceled branch December 19, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EF: Handle OperationCanceledException instead of TaskCanceledException in UnhandledExceptionLoggingFilter

2 participants