Repository navigation
fix(web): add accessible legend to dashboard trends - #1819
Open
misaelalves99 wants to merge 1 commit into
Open
misaelalves99 wants to merge 1 commit into
misaelalves99 wants to merge 1 commit into
Conversation
joshunrau
requested changes
Oct 25, 2026
joshunrau
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this. The legend, the translated series names and the dashed sessions line are exactly what #1782 asked for, and the tests cover them well. One small thing before it can go in:
- Define the series labels once. The new
nameprops inapps/web/src/routes/_app/dashboard.tsx(lines 511-515 and 526-530) repeat thet({ en: 'Records', ... })andt({ en: 'Sessions', ... })calls that the tooltip already makes at lines 482-486 and 490-494. In this repo an inlinet()is only for a string used once. Otherwise the legend and tooltip can drift apart when one copy changes. Please hoist them intoconst recordsLabel = t({...})andconst sessionsLabel = t({...})in the component body (seeapps/web/src/components/UserPermissionsEditor/UserPermissionsEditor.tsx:110for the pattern), then use those in both the tooltip and thenameprops. Your existing tests should pass unchanged.
If you hand this to Claude Code, Sonnet 5 is the right size. It is one mechanical edit in a single file.
Reviewed at commit eaa4d94.
This was referenced Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1782.
Summary
The dashboard's Records & Sessions Trend chart previously relied on color and hover tooltips to identify its two data series.
This change:
Validation
pnpm lintcommand was not run because it can invoke code-modifying generators or fixers.Known E2E environment limitation
The isolated full Playwright run finished with 278 passed and 1 failed.
The sole failure was in
testing/src/specs/record-file-deletion.spec.ts, which expected HTTP 201 when creating a FILE instrument record but received HTTP 503.The isolated environment had
STORAGE_ENABLED=false. ExistingInstrumentRecordsService.create()logic explicitly rejects FILE records when storage is disabled.This test is outside the files changed by this PR. The failure is documented as an environment/configuration limitation, and the complete E2E suite is not claimed to be passing.
A separate cross-browser smoke run produced 41/42 passes due to a Chromium subject-detail interaction timeout. A targeted Chromium rerun subsequently passed 7/7. The intermittent cause was not established.
Scope
Only three files are modified:
apps/web/src/routes/_app/dashboard.tsxapps/web/src/routes/_app/__tests__/dashboard.test.tsxtesting/src/specs/dashboard.spec.tsNo new dependencies or unrelated source changes.