Repository navigation
Conversation
MattKotsenas
added a commit
to MattKotsenas/MattKotsenas
that referenced
this pull request
Sep 5, 2026
## Summary - monitor TLS certificate validity, certificate lifetime, and HTTP availability for every public blog domain - use the maintained DotNetDiag health-check packages with an operation-level timeout around third-party checks - expose the checks through `aspire do check-public-https` and run them daily ## Upstream follow-up - DotNetDiag/HealthChecks#40 tracks cancellation during a stalled TLS handshake - Xabaril/AspNetCore.Diagnostics.HealthChecks#2485 tracks the same issue in the original package - DotNetDiag/HealthChecks#41 contains the proposed fix The outer timeout remains useful because synchronous certificate verification cannot observe cancellation. ## Scope This is the first replacement slice for #10. It adds monitoring only and leaves deployment resources and public DNS routing unchanged. The scheduled workflow reads `AZURE_DEPLOYMENT_PRINCIPAL_ID` from the repository variable used by the existing preview AppHost environment.
maikebing
approved these changes
Sep 7, 2026
maikebing
left a comment
There was a problem hiding this comment.
Reviewed locally. The cancellation fix correctly passes the token to TLS authentication on NET5+ and disposes/awaits the NETSTANDARD2.0 handshake on cancellation. dotnet format passed for both projects; source builds for netstandard2.0/net8.0/net10.0; targeted regression and SSL timeout tests passed on net8.0 and net10.0. GitHub Actions are currently action_required for this fork PR, so CI did not run.
This was referenced Oct 5, 2026
This was referenced Oct 12, 2026
This was referenced Oct 26, 2026
This was referenced Nov 2, 2026
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #40
Related: Xabaril#2485
Why
SslHealthCheckalready applies cancellation while opening the TCP connection, but not during the TLS handshake. A peer can accept the connection and then remain silent, leaving the check pending beyond its configured timeout.The .NET Standard fallback deliberately does not use
WithCancellationTokenAsync. That helper returns on cancellation while abandoning the original authentication task, which can later fault unobserved when the stream is disposed. The fallback instead disposes the stream to interrupt authentication and awaits the task before translating the result toOperationCanceledException.Validation
masteratc9d3d49ewith an accepted connection and ClientHello in flightHealthChecks.Networkbuilds for .NET Standard 2.0, .NET 8, and .NET 10HealthChecks.Network.Testsbuilds for .NET 8 and .NET 10OperationCanceledExceptionand no unobserved task exceptionNote that
X509Certificate2.Verify()is synchronous and remains outside cancellation.