feat(policy)!: remove replacement warning acknowledgement - #111
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Benoît Cortier (CBenoit)
September 19, 2026 04:31
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The breaking contract change is consistently implemented and covered by compatibility tests, with only minor release-documentation follow-up remaining.
Review effort: Balanced
Findings: None
What changed in this PR
Removes protocol-level warning acknowledgement from policy replacement contracts across Rust, .NET, OpenAPI, and shared fixtures.
Changes:
- Removes
WarningsAcknowledgedand its obsolete error code. - Adds strict legacy-payload rejection tests.
- Bumps Rust API and server-template crates to 0.7.0.
| File | Description |
|---|---|
| policies/test-data/package-broker/requests/policy-replacement.update.request.json | Updates the update fixture. |
| policies/test-data/package-broker/requests/policy-replacement.replace-identity.request.json | Updates the identity-replacement fixture. |
| policies/test-data/package-broker/requests/policy-replacement.repair.request.json | Updates the repair fixture. |
| policies/test-data/package-broker/requests/policy-replacement.overwrite.request.json | Updates the overwrite fixture. |
| policies/test-data/package-broker/requests/policy-replacement.create.request.json | Updates the creation fixture. |
| policies/rust/now-policy-server-template/tests/sample_documents.rs | Tests legacy-field rejection and revised behavior. |
| policies/rust/now-policy-server-template/src/server.rs | Removes the obsolete error mapping. |
| policies/rust/now-policy-server-template/Cargo.toml | Bumps the template and API dependency versions. |
| policies/rust/now-policy-api/src/management.rs | Removes the Rust request field. |
| policies/rust/now-policy-api/src/enums.rs | Removes the Rust error variant. |
| policies/rust/now-policy-api/README.md | Documents advisory warning behavior. |
| policies/rust/now-policy-api/openapi/now-policy-api.yaml | Updates the wire schema. |
| policies/rust/now-policy-api/Cargo.toml | Bumps the API crate version. |
| policies/dotnet/Devolutions.Now.Policy.Client.Tests/PolicyManagementClientTests.cs | Tests strict legacy-field rejection. |
| policies/dotnet/Devolutions.Now.Policy.Api/README.md | Documents advisory warning behavior. |
| policies/dotnet/Devolutions.Now.Policy.Api/PolicyManagementModels.cs | Removes the .NET request property. |
| policies/dotnet/Devolutions.Now.Policy.Api/Enums.cs | Removes the .NET error value. |
| Cargo.lock | Records updated Rust package versions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Sep 19, 2026
Benoît Cortier (CBenoit)
deleted the
cbenoit-policy-warning-contract
branch
September 19, 2026 14:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WarningsAcknowledgedfromPolicyReplacementRequestin the Rust and .NET API models, OpenAPI schema, and all shared fixtures.WarningConfirmationRequirederror code while retaining validation receipts, validation findings, store-token concurrency, and explicit overwrite confirmation.now-policy-apiandnow-policy-server-templateto 0.7.0 and require the template's new API version.