Skip to content

ci(release): release the newly published crates - #2218

Merged
Benoît Cortier (CBenoit) merged 1 commit into
masterfrom
claude/release-reenable-crates
Oct 26, 2026
Merged

Benoît Cortier (CBenoit) merged 1 commit into
masterfrom
claude/release-reenable-crates

Conversation

@CBenoit

Copy link
Copy Markdown
Member

The nine crates first published by hand (ironrdp-rdpeudp, ironrdp-rdpemt, ironrdp-rdpeudp-tokio, ironrdp-rdpeai, ironrdp-rdpewa, ironrdp-rdpewa-native, ironrdp-rdpeusb, ironrdp-rpc, ironrdp-vmconnect) now exist on crates.io, so release-plz can release them again, along with ironrdp-server and ironrdp-rdpsnd-native, whose dependencies are all published. ironrdp-rdpewa-native skips publish verification like the other native crates.

ironrdp-client stays excluded because its video feature depends on ironrdp-rdpegt and ironrdp-rdpevor, which are publish = false; ironrdp, ironrdp-daemon, ironrdp-agent and ironrdp-viewer depend on it and stay excluded too. ironrdp-rdpeusb-native is new and builds only against unreleased changes in ironrdp-rdpeusb and ironrdp-usb, so it is excluded until those are released and it is published manually.

🤖 Generated with Claude Code

The nine crates first published by hand (ironrdp-rdpeudp, ironrdp-rdpemt, ironrdp-rdpeudp-tokio, ironrdp-rdpeai, ironrdp-rdpewa, ironrdp-rdpewa-native, ironrdp-rdpeusb, ironrdp-rpc, ironrdp-vmconnect) now exist on crates.io, so release-plz can release them again, along with ironrdp-server and ironrdp-rdpsnd-native, whose dependencies are all published. ironrdp-rdpewa-native skips publish verification like the other native crates.

ironrdp-client stays excluded because its `video` feature depends on ironrdp-rdpegt and ironrdp-rdpevor, which are `publish = false`; ironrdp, ironrdp-daemon, ironrdp-agent and ironrdp-viewer depend on it and stay excluded too. ironrdp-rdpeusb-native is new and builds only against unreleased changes in ironrdp-rdpeusb and ironrdp-usb, so it is excluded until those are released and it is published manually.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 24, 2026 12:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused configuration changes match the stated publishing prerequisites, with no unresolved findings.

No open issues 🎉

What changed in this PR

This PR restores automated releases for newly published crates and their now-unblocked dependents while keeping crates with unmet publishing prerequisites excluded.

Changes:

  • Re-enable releases for nine newly published crates, plus ironrdp-server and ironrdp-rdpsnd-native.
  • Skip publish verification for ironrdp-rdpewa-native, consistent with other native crates.
  • Exclude ironrdp-rdpeusb-native and clarify why the remaining blocked crates stay excluded.
File Description
release-plz.toml Updates release eligibility, native publish verification, and comments explaining exclusions.

Review effort: Balanced

@github-actions github-actions Bot added risk/low Self-contained change with no cross-crate behavioral effect size/XS Size: up to 49 counted lines and 2 files triage/overlap Possible overlap with another pull request; advisory only labels Oct 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request may overlap with #2215.

Both PRs concern which workspace crates are published to crates.io: this PR rewrites the release-plz.toml exclusion list (adding ironrdp-daemon and ironrdp-rdpeusb-native as release=false, removing exclusions for server, rdpeudp, rdpeusb and others), while #2215 is a release-preparation PR that bumps versions and lists an initial ironrdp-rdpeusb-native 0.1.0 publish, touching the same publishing surface.

This notice is advisory only. Automated review continues as usual, and how these pull requests relate is for maintainers and authors to decide.

Note

LLM-assisted content (no human feedback).

@CBenoit

Copy link
Copy Markdown
Member Author

Merge order: this should land before #2215. #2215 includes a first publish of ironrdp-rdpeusb-native 0.1.0, which trusted publishing cannot create, so its release run would stop partway as the ironrdp-rail one did. Merging this first makes release-plz regenerate the release PR without that crate.

Note

LLM-assisted content (no human feedback).

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Configuration-only change to release-plz.toml that re-enables release-plz for nine crates published manually (rdpeudp, rdpemt, rdpeudp-tokio, rdpeai, rdpewa, rdpewa-native, rdpeusb, rpc, vmconnect) plus ironrdp-server and ironrdp-rdpsnd-native, adds ironrdp-rdpewa-native to the publish_no_verify native group, and consolidates the remaining exclusions (ironrdp, ironrdp-daemon, ironrdp-rdpeusb-native) under one updated rationale comment. Independently verified against pr-head: ironrdp-client's video feature depends on ironrdp-rdpegt and ironrdp-rdpevor, both publish = false (crates/ironrdp-rdpegt/Cargo.toml:4, crates/ironrdp-rdpevor/Cargo.toml:4, crates/ironrdp-client/Cargo.toml:54), ironrdp optionally depends on ironrdp-client (crates/ironrdp/Cargo.toml:83), ironrdp-agent depends on ironrdp-daemon (crates/ironrdp-agent/Cargo.toml:28), and ironrdp-rdpsnd-native's dependencies (rdpeai 0.1, rdpsnd 0.10) match the newly published versions. No errors found; the validated specialist aggregat…

@github-actions github-actions Bot added ai-reviewed/1 One automated review completed needs-review A human reviewer is the current next actor labels Oct 24, 2026
@CBenoit
Benoît Cortier (CBenoit) merged commit 06e2d6f into master Oct 26, 2026
45 checks passed
@CBenoit
Benoît Cortier (CBenoit) deleted the claude/release-reenable-crates branch October 26, 2026 16:16
@github-actions github-actions Bot removed the needs-review A human reviewer is the current next actor label Oct 26, 2026
Anton Mostovoy (antonmos) added a commit to antonmos/IronRDP that referenced this pull request Oct 26, 2026
…ktop-scale-factor

* upstream/master: (92 commits)
  fix(server): advertise horizontal mouse wheel input (Devolutions#2236)
  fix(pdu): reject RSA moduli below 512 bits (Devolutions#2225)
  ci(ffi): verify generated bindings (Devolutions#2166)
  build(ffi)!: move to Diplomat 0.16.1-devo.2 (Devolutions#2165)
  build: make the client's video, camera and decoder crates publishable (Devolutions#2239)
  ci(release): release the newly published crates (Devolutions#2218)
  perf(graphics): replace the RLGR decoder's bit reader (Devolutions#2150)
  chore(graphics): add RemoteFX decode benchmarks (Devolutions#2149)
  fix(server)!: pass a GfxContext to the GfxServerFactory build methods (Devolutions#2104)
  fix(pdu): check remaining length when skipping padding and reading client core data (Devolutions#2130)
  fix(session): avoid hang on empty QOIZ updates (Devolutions#2147)
  feat(session): expose EGFX compositing (Devolutions#2120)
  fix(server): send RDP as the Demand Active source descriptor (Devolutions#2119)
  feat(activex)!: broaden mstscax compatibility (Devolutions#2211)
  feat(viewer): run RemoteApp programs in native windows (Devolutions#2201)
  fix(graphics): reject RLGR3 values larger than their remainder (Devolutions#2132)
  feat(egfx)!: composite surfaces mapped to RemoteApp windows (Devolutions#2197)
  feat: redirect USB devices over URBDRC with nusb and RemoteFX USB backends (Devolutions#2181)
  build: mark exposed dependencies as public (Devolutions#2213)
  chore(release): prepare for publishing (Devolutions#2212)
  ...

# Conflicts:
#	crates/ironrdp-testsuite-extra/tests/e2e.rs

This branch was previously deployed

1 inactive deployment
llm-providers — e36a631b Deployed Oct 24, 2026 by CBenoit via Classify pull request #7973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-reviewed/1 One automated review completed risk/low Self-contained change with no cross-crate behavioral effect size/XS Size: up to 49 counted lines and 2 files triage/overlap Possible overlap with another pull request; advisory only

Development

Successfully merging this pull request may close these issues.

2 participants