Repository navigation
fix(egfx): respect client frame acknowledgement limits - #2102
Open
Piclaw (piclaw-bot) wants to merge 1 commit into
Open
Piclaw (piclaw-bot) wants to merge 1 commit into
Piclaw (piclaw-bot) wants to merge 1 commit into
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client advertising a one-frame ACK window can currently be sent frames using the server's larger configured window. An AVC producer also receives the same
Nonefor a full window as for a permanent submission error, which makes ordinary backpressure difficult to handle without replacing the encoder.This PR is based directly on
masterand is independent of #1413. It contains no credential, binder or acceptor changes.Unavailable: our client counts frames, while the protocol field measures bytes. This is distinct fromSuspend.Backpressured, while retaining the existingOptionmethods as compatibility wrappers. Mixed-codec send APIs are unchanged.WRDP exposed the configured-three/client-one case during desktop dragging. These changes let the producer retain its encoder and retry/recover after an ACK instead of treating backpressure as encoder failure.
Focused checks passed locally (Rust 1.96; the repository pins 1.94.1):
Regressions cover window/zero semantics, activation clamps, resize, legacy factories, stale suspend/resume ACKs across close/reopen, restored tracking after valid resume, and typed rejection without queued output. A read-only review caught the legacy-factory and suspended-ACK resume paths; both are corrected and covered here.
Happy to adjust the additive error API to the project's preferred shape during review. This PR can be reviewed and merged separately from the session-binding work.