Repository navigation
build: support linux-arm64 build of wasm2wat - #2035
Merged
Benoît Cortier (CBenoit) merged 1 commit intoSep 29, 2026
Merged
Benoît Cortier (CBenoit) merged 1 commit into
Benoît Cortier (CBenoit) merged 1 commit into
Conversation
Jérémie Laval (jeremie-stripe)
deployed
to
llm-providers
September 28, 2026 13:55 — with
GitHub Actions
Active
Copilot started reviewing on behalf of
Jérémie Laval (jeremie-stripe)
September 28, 2026 13:55
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted platform selection is correct and preserves existing behavior elsewhere.
Review effort: Balanced
Findings: None
What changed in this PR
Adds Linux ARM64 support when installing wasm2wat for WASM validation.
Changes:
- Selects WABT’s
linux-arm64artifact on AArch64 Linux hosts. - Retains
linux-x64for other Linux architectures.
No material issues identified; protocol and documentation passes were not applicable.
| File | Description |
|---|---|
xtask/src/wasm.rs |
Selects the architecture-appropriate Linux WABT archive. |
[!NOTE]
LLM-assisted content (no human feedback).
Benoît Cortier (CBenoit)
approved these changes
Sep 29, 2026
Benoît Cortier (CBenoit)
left a comment
Member
There was a problem hiding this comment.
LGTM, thank you!
Benoît Cortier (CBenoit)
enabled auto-merge (squash)
September 29, 2026 05:48
Benoît Cortier (CBenoit)
merged commit Sep 29, 2026
c003152
into
Devolutions:master
52 of 54 checks passed
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the logic that downloads the
wasm2wattool from wabt to support linux-arm64 as a target (previously hardcoded to linux-x64).This is used to validate the wasm build.
Validated this work on my linux-arm64 machine by running:
(Redacted some section of output since they were not relevant and contained private details)
I hit this issue trying to validate this PR #2004