[Greg Lamberson (glamberson)]

#1877 (clipboard image support) merged: This PR now rebases cleanly onto
master and its own diff is HTML-only. It still depends on the
ClipboardContent enum #1877 introduced.

Extends the daemon clipboard-get/clipboard-set operations to HTML fragments:
clipboard-get-html prints the last HTML fragment received from the remote
clipboard, clipboard-set-html sets one and advertises it to the remote as
the registered HTML Format.

Stores the fragment as plain text (not yet CF_HTML-wrapped) and converts at
the point of use via ironrdp-cliprdr-format's existing
plain_html_to_cf_html/cf_html_to_plain_html, so no new markup handling is
needed here, mirroring the image PR's use of the crate's existing bitmap
conversions.

HTML Format is a registered, not fixed-ID, clipboard format: The offering
side picks a private-range ID (0xC000 here) and pairs it with the name; the
receiver learns the ID-to-name mapping from the FormatList. When receiving,
matches the remote's offer by name and uses whatever ID it assigned, not the
locally-chosen one, since those only apply to formats this backend itself
offers.

Extends the remote-copy priority order to image, then HTML, then text
(richest representation first), and the PendingPaste tracking added in
#1877 with an Html variant so a returned FormatDataResponse is decoded
correctly regardless of which of the three was requested. A remote HTML
fragment over the 256 KiB bound is dropped and logged rather than stored,
mirroring the oversized-image drop #1877's review round added, for the same
reason: An unbounded stored value would otherwise fail encoding once handed
back over the RPC transport.

New Request::ClipboardGetHtml/ClipboardSetHtml and Payload::ClipboardHtml
wire variants, bounded at 256 KiB in the CLI parser and on wire decode.
Extends ironrdp-activex's exhaustive match on Request with the same
treatment as the other clipboard operations. Extends the wire round-trip
and Debug-redaction test coverage added in #1877 to the two new variants.

cargo xtask check fmt/lints/tests/typos/locks all pass. Not yet verified
against a live remote client, same as #1877.

[Greg Lamberson (glamberson)]

The duplicate label here is the intentional cross-fork stacking pattern noted in #1877's stacking comment, not an actual duplicate: this PR depends on the ClipboardContent enum #1877 introduces, and since GitHub-native stacked PRs cannot span the fork boundary, this PR's diff is filed cumulatively against master rather than against #1877's branch. Flagging in case it's useful signal for the duplicate detector's false-positive rate.

[Copilot]

🟡 Changes recommended

Decode diagnostics violate the repository’s offset convention, and several messages misstate the new HTML behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds daemon clipboard HTML support using registered HTML Format negotiation and existing CF_HTML conversions.

Changes:

• Adds HTML clipboard RPC and CLI variants with 256 KiB bounds.
• Handles HTML advertisement, transfer, conversion, and prioritization.
• Extends ActiveX handling and wire/redaction tests.

File summaries

File	Description
crates/ironrdp-testsuite-extra/tests/agent.rs	Tests HTML RPC variants and redaction.
crates/ironrdp-rpc/src/ipc.rs	Defines bounded HTML requests and payloads.
crates/ironrdp-daemon/src/daemon.rs	Implements HTML get/set handlers.
crates/ironrdp-daemon/src/clipboard.rs	Adds CF_HTML CLIPRDR behavior.
crates/ironrdp-agent/src/help.rs	Documents HTML commands.
crates/ironrdp-agent/src/cli.rs	Adds HTML CLI parsing and output.
crates/ironrdp-activex/src/rpc.rs	Marks HTML operations unavailable through ActiveX.

Review details

Suppressed comments (2)

crates/ironrdp-rpc/src/ipc.rs:2643

• This decode error also omits the cursor context required by STYLE.md:110-114, which drops the failing byte offset from diagnostics. Pass in: src here as well.

                    return Err(ironrdp_core::invalid_field_err!("clipboard html", "too large"));

crates/ironrdp-daemon/src/daemon.rs:1152

• The new HTML outcome is missing from this method's documentation, which says None only covers no content or text. Update it so callers know to query clipboard_get_html when the current item is HTML.

            Some(crate::clipboard::ClipboardContent::Text(_) | crate::clipboard::ClipboardContent::Html(_)) | None => {

• Files reviewed: 7/7 changed files
• Comments generated: 4
• Review effort level: Balanced

[Benoît Cortier (CBenoit)]

The duplicate label here is the intentional cross-fork stacking pattern noted in #1877's stacking comment, not an actual duplicate: this PR depends on the ClipboardContent enum #1877 introduces, and since GitHub-native stacked PRs cannot span the fork boundary, this PR's diff is filed cumulatively against master rather than against #1877's branch. Flagging in case it's useful signal for the duplicate detector's false-positive rate.

Thank you! There is chance it may be looking at this, but the fix is to open the PRs as draft until they are rebased and ready to be reviewed; the classifier will not run against it until it is marked as ready. It’s probably better so it actually reviews the diff without the stacked work.

[github-actions]

HTML clipboard support added across CLI, daemon CLIPRDR backend, RPC wire layer, ActiveX stub, and tests. Independent review confirms protocol-conformant registered-format handling (self-chosen 0xC000 ID when advertising, by-name match using the peer's ID when receiving), symmetric bounded wire codecs (Request tags 33/34, Payload tag 15), and plumbing consistent with the #1877 precedent. Only two low-severity compression candidates existed: one accepted (duplicate print arm), one rejected (inlining remote_html_id would diverge from the sibling precompute-then-branch style). No correctness, safety, protocol, or maintainability defects found.