Repository navigation
build: mark exposed dependencies as public - #2213
Merged
Merged
Conversation
These crates expose types or traits from these dependencies in their public API, so a breaking release of the dependency requires a breaking release of the crate: - `ironrdp-str`: `ironrdp-core`, whose `Encode` and `DecodeOwned` traits the string types implement. - `ironrdp-dvc-pipe-proxy`: `ironrdp-dvc`, through `DvcNamedPipeProxy`'s `DvcProcessor` implementation. - `ironrdp-dvc-com-plugin`: `ironrdp-dvc`, plus `ironrdp-pdu` and `ironrdp-svc` through the `PduResult` return type and the `SvcMessage` callback bound of `load_dvc_plugin`. - `ironrdp-mstsgu`: `ironrdp-error`, whose `Error<GwErrorKind>` the `GwClient` methods return. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Lines changed: production code 0, tests 0, other 6 (manifest comments only: Note LLM-assisted content (no human feedback). |
Benoît Cortier (CBenoit)
temporarily deployed
to
llm-providers
October 23, 2026 16:31 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All six annotations match existing public API exposure, and the comment-only changes leave no unresolved issues.
No open issues 🎉
What changed in this PR
This PR marks six existing dependencies as public API dependencies, documenting their relevance to breaking-release decisions.
Changes:
- Adds
# publicannotations across four crate manifests. - Includes type notes for the COM plugin’s exposed
PduResultandSvcMessagedependencies. - Leaves dependency versions, features, and runtime behavior unchanged.
| File | Description |
|---|---|
| crates/ironrdp-str/Cargo.toml | Marks ironrdp-core public for implemented traits. |
| crates/ironrdp-mstsgu/Cargo.toml | Marks ironrdp-error public for returned error types. |
| crates/ironrdp-dvc-pipe-proxy/Cargo.toml | Marks ironrdp-dvc public for its processor trait implementation. |
| crates/ironrdp-dvc-com-plugin/Cargo.toml | Marks ironrdp-pdu, ironrdp-dvc, and ironrdp-svc public. |
Review effort: Balanced
github-actions
Bot
added
automation-failed
…arkers # Conflicts: # crates/ironrdp-dvc-com-plugin/Cargo.toml # crates/ironrdp-dvc-pipe-proxy/Cargo.toml # crates/ironrdp-mstsgu/Cargo.toml # crates/ironrdp-str/Cargo.toml
Benoît Cortier (CBenoit)
temporarily deployed
to
llm-providers
October 23, 2026 18:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This was referenced Oct 23, 2026
Anton Mostovoy (antonmos)
added a commit
to antonmos/IronRDP
that referenced
this pull request
Oct 26, 2026
…ktop-scale-factor * upstream/master: (92 commits) fix(server): advertise horizontal mouse wheel input (Devolutions#2236) fix(pdu): reject RSA moduli below 512 bits (Devolutions#2225) ci(ffi): verify generated bindings (Devolutions#2166) build(ffi)!: move to Diplomat 0.16.1-devo.2 (Devolutions#2165) build: make the client's video, camera and decoder crates publishable (Devolutions#2239) ci(release): release the newly published crates (Devolutions#2218) perf(graphics): replace the RLGR decoder's bit reader (Devolutions#2150) chore(graphics): add RemoteFX decode benchmarks (Devolutions#2149) fix(server)!: pass a GfxContext to the GfxServerFactory build methods (Devolutions#2104) fix(pdu): check remaining length when skipping padding and reading client core data (Devolutions#2130) fix(session): avoid hang on empty QOIZ updates (Devolutions#2147) feat(session): expose EGFX compositing (Devolutions#2120) fix(server): send RDP as the Demand Active source descriptor (Devolutions#2119) feat(activex)!: broaden mstscax compatibility (Devolutions#2211) feat(viewer): run RemoteApp programs in native windows (Devolutions#2201) fix(graphics): reject RLGR3 values larger than their remainder (Devolutions#2132) feat(egfx)!: composite surfaces mapped to RemoteApp windows (Devolutions#2197) feat: redirect USB devices over URBDRC with nusb and RemoteFX USB backends (Devolutions#2181) build: mark exposed dependencies as public (Devolutions#2213) chore(release): prepare for publishing (Devolutions#2212) ... # Conflicts: # crates/ironrdp-testsuite-extra/tests/e2e.rs
This was referenced Oct 27, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These crates expose types or traits from these dependencies in their public API, so a breaking release of the dependency requires a breaking release of the crate:
ironrdp-str:ironrdp-core, whoseEncodeandDecodeOwnedtraits the string types implement.ironrdp-dvc-pipe-proxy:ironrdp-dvc, throughDvcNamedPipeProxy'sDvcProcessorimplementation.ironrdp-dvc-com-plugin:ironrdp-dvc, plusironrdp-pduandironrdp-svcthrough thePduResultreturn type and theSvcMessagecallback bound ofload_dvc_plugin.ironrdp-mstsgu:ironrdp-error, whoseError<GwErrorKind>theGwClientmethods return.🤖 Generated with Claude Code