Repository navigation
Conversation
jest-expo and eslint-config-expo follow the Expo SDK major. The dev-dependencies group bumped them to 58 (Devitek#247) while the app is on SDK 57: jest-expo 58 maps react-native/asset-registry to src/asset-registry.js, which does not exist in RN 0.86, so every Jest suite fails at setup, and eslint-config-expo 58 fails expo-doctor. Ignore their semver-major updates, like the other SDK-driven packages. Patches stay aligned through npx expo install --fix.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quoi & pourquoi
Closes #249.
Dependabot's
dev-dependenciesgroup bumpedjest-expoandeslint-config-expoto 58 (#247) while the app is on SDK 57.jest-expo@58mapsreact-native/asset-registryto a path that only exists in RN 0.88, so every Jest suite fails at setup, andeslint-config-expo@58fails expo-doctor. Details and evidence in #249.This adds both packages to the Dependabot ignore list for
semver-major, alongside the other SDK-driven packages. Patches keep flowing (andnpx expo install --fixkeeps them aligned). Majors move with the SDK upgrade. Once merged, Dependabot should regenerate #247 with only@babel/coreandprettier, which pass every check locally.Only
.github/dependabot.ymlchanges (9 lines, comment in French like the rest of the file).Note: CI on this branch will hit the existing expo-doctor drift until #248 (closes #231) is merged. Updating the branch after that should make it green.
Definition of Done
npm run format:checkvert on the changed file; no code change (CI will confirm the full gate once chore(deps): realign Expo SDK patches #248 lands)CHANGELOG.md/ versions / tags (release-please)