Repository navigation
fix: correct linear rollout interpolation from non-zero percentages - #314
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The zero-progress guard still briefly returns 0 after a non-zero stage.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Corrects linear rollout interpolation for non-zero percentages in local bucketing.
Changes:
- Applies the correct interpolation formula.
- Adds regression coverage for gradual rollout, rollback, and staged transitions.
| File | Description |
|---|---|
bucketing/bucketing.go |
Fixes rollout percentage calculation. |
bucketing/bucketing_test.go |
Adds interpolation regression tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
JamieSinn
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
getCurrentRolloutPercentageto computec + (n - c) * tfor linear stages; a misplaced parenthesis meant it computedn * t, which drops the rollout below the current stage percentage whenever it's non-zero@devcycle/bucketingimplementationRelated Issues
Fixes #312
Relates to: DevCycleHQ/test-harness#615