Repository navigation
Conversation
KubeRay resolves clusterSelector as a RayCluster name, and a RayService names its cluster <name>-<random> and replaces it on every upgrade. When ray.existing_cluster names a RayService in the task namespace, the plugin substitutes the RayService's active RayCluster. Other names pass through. A RayService without an active cluster returns a retryable error. BuildResource gets no Kubernetes client, so the plugin creates one on first use from the in-cluster or remote cluster config. Flyte's service account needs get on rayservices.ray.io. Signed-off-by: Christian <chjdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KubeRay resolves clusterSelector as a RayCluster name, and a RayService names its cluster - and replaces it on every upgrade. When ray.existing_cluster names a RayService in the task namespace, the plugin substitutes the RayService's active RayCluster. Other names pass through. A RayService without an active cluster returns a retryable error.
BuildResource gets no Kubernetes client, so the plugin creates one on first use from the in-cluster or remote cluster config. Flyte's service account needs get on rayservices.ray.io.
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Stack
If you do use
git townto manage PR Stacks, the stack relevant to this PRwill show below. Otherwise, you can ignore this section.
Docs link