You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Debugger scenarios execute expensive probe installation, request, diagnostic,
and snapshot setup even when the current library manifest declares the test
missing. The assertion then xfails, but only after the setup has consumed its
full waits.
This is especially costly for DEBUGGER_EXPRESSION_LANGUAGE: Go declares the
entire class missing while the repository timing data records roughly 1,035
seconds for the scenario.
Changes
Mark the expression-language class as slow, converting only tests with an
active manifest declaration into early skips.
Mark the missing exception-replay in-product enablement test as slow. Its
existing multiconfig sibling already uses the same mechanism.
Supported libraries and versions continue running the tests normally. Once a
manifest declaration is removed, the marker becomes a no-op.
Validation
Node.js Express 4 local comparisons:
DEBUGGER_EXPRESSION_LANGUAGE: 143.66 seconds before; 78.31 seconds after.
The optimized run had 10 passed and 2 skipped.
DEBUGGER_INPRODUCT_ENABLEMENT: 129.39 seconds before; 80.54 seconds after.
The optimized run had 1 passed and 4 skipped.
Mypy: 556 source files passed.
Ruff formatting and lint: passed.
The Go impact is inferred from its class-level missing_feature declaration
and checked-in timing data; a Go weblog was not built locally.
Workflow
⚠️ Create your PR as draft ⚠️
Work on you PR until the CI passes
Mark it as ready for review
Test logic is modified? -> Get a review from RFC owner.
Framework is modified, or non obvious usage of it -> get a review from R&P team
🚀 Once your PR is reviewed and the CI green, you can merge it!
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.
Before you start, set up the Datadog software-delivery tooling so you can
query the CI data yourself:
1. Check whether you already have the Datadog software-delivery MCP tools
(e.g. a `search_datadog_ci_pipeline_events` tool) and the `unblock-pr` skill.
2. If either is missing, STOP and ask me for permission before installing
anything. Do not install or run anything until I have said yes.
3. Only with my explicit approval, set up the Datadog software-delivery MCP
server and skills by following:
https://docs.datadoghq.com/getting_started/software_delivery_mcp_tools/
then restart so the skill is picked up.
4. If I decline, skip all of the above and work from the context below alone.
Then run /unblock-pr — it will pull the CI data itself. The job context below is what we already know.
If /unblock-pr is not available — because I declined the setup above, or it did not install — work from the context below instead.
Datadog has already classified this failure as caused by changes in this PR.
Take that as given and work the fix:
1. Locate the change. Diff this branch against its base and find the change
that produces this error. Explain the mechanism, don't just name a file:
git fetch origin && git diff $(git merge-base origin/main HEAD)...HEAD
2. Reproduce it locally. Run the failing job's command or test before
proposing anything.
3. Propose the smallest fix that addresses the root cause — not a workaround,
not a broadened assertion, not a disabled or skipped test.
4. Re-run the same command to confirm, and say exactly what you ran.
5. If the failure turns out to be intermittent rather than deterministic, say
so plainly instead of "fixing" it — that is a flaky test, and patching it
hides the problem.
If the right move is to re-run the job rather than change code, use the job
link in the context below. For GitHub Actions: `gh run rerun <run-id> --failed`,
where the run ID is the number after `/runs/` in that URL (not the trailing
number, which is the job ID).
Branch: rochdev/debugger-skip-missing-tests
Testing the test | System Tests (php, dev) / Build end-to-end (laravel11x)
Commit: af8da69284b669456eedce3abff483f21a705068
Error (code / build):
Error in Dockerfile: can't read /etc/apt/sources.list: No such file or directory at line 10
CI job: https://github.com/DataDog/system-tests/actions/runs/34406894442/job/102653344024
The reason will be displayed to describe this comment to others. Learn more.
More details
The slow markers convert active manifest declarations into collection-time skips. Tests without an active declaration still run their debugger setup and assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Debugger scenarios execute expensive probe installation, request, diagnostic,
and snapshot setup even when the current library manifest declares the test
missing. The assertion then xfails, but only after the setup has consumed its
full waits.
This is especially costly for
DEBUGGER_EXPRESSION_LANGUAGE: Go declares theentire class missing while the repository timing data records roughly 1,035
seconds for the scenario.
Changes
active manifest declaration into early skips.
existing multiconfig sibling already uses the same mechanism.
manifest declaration is removed, the marker becomes a no-op.
Validation
Node.js Express 4 local comparisons:
DEBUGGER_EXPRESSION_LANGUAGE: 143.66 seconds before; 78.31 seconds after.The optimized run had 10 passed and 2 skipped.
DEBUGGER_INPRODUCT_ENABLEMENT: 129.39 seconds before; 80.54 seconds after.The optimized run had 1 passed and 4 skipped.
The Go impact is inferred from its class-level
missing_featuredeclarationand checked-in timing data; a Go weblog was not built locally.
Workflow
R&P team
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified? I have the approvalfrom R&P team
build-XXX-imagelabel is presentGenerated by Codex.