Skip to content

test(otel): cover OTEL_METRIC_EXPORT_TIMEOUT parametrically - #7682

Merged
vpellan merged 5 commits into
mainfrom
vpellan/OTEL_METRIC_EXPORT_TIMEOUT
Sep 17, 2026
Merged

vpellan merged 5 commits into
mainfrom
vpellan/OTEL_METRIC_EXPORT_TIMEOUT

Conversation

@vpellan

@vpellan vpellan commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Motivation

Add specification-based parametric coverage for OTEL_METRIC_EXPORT_TIMEOUT.

Tracks APMAPI-2397.

Changes

  • Test representative values, unset, empty and default values, and configuration
    precedence.
  • Declare support in every tracer manifest from the configuration registry.
  • Declare spec default as irrelevant for all SDKs but PHP

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from
      R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛏 #apm-shared-testing 🛏

Reviewer checklist

  • Anything but tests/ or manifests/ is modified? I have the approval
    from R&P team
  • A docker base image is modified?
    • The relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@vpellan
vpellan requested review from a team as code owners September 9, 2026 12:15
@vpellan
vpellan requested review from mtoffl01 and removed request for a team September 9, 2026 12:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T12:23:28.345135Z 4ecff7c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/parametric/otel_env_vars/test_otel_metric_export_timeout.py       @DataDog/system-tests-reviewers
manifests/cpp.yml                                                       @DataDog/system-tests-reviewers
manifests/dotnet.yml                                                    @DataDog/system-tests-reviewers
manifests/golang.yml                                                    @DataDog/system-tests-reviewers
manifests/java.yml                                                      @DataDog/system-tests-reviewers
manifests/nodejs.yml                                                    @DataDog/system-tests-reviewers
manifests/php.yml                                                       @DataDog/system-tests-reviewers
manifests/python.yml                                                    @DataDog/system-tests-reviewers
manifests/ruby.yml                                                      @DataDog/system-tests-reviewers
manifests/rust.yml                                                      @DataDog/system-tests-reviewers

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Sep 9, 2026

Copy link
Copy Markdown

Tests

All CI checks and tests passed.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 016ba6f | Docs | View more details | Give us feedback!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ecff7c4ff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/parametric/otel_env_vars/test_otel_metric_export_timeout.py Outdated
Comment thread tests/parametric/otel_env_vars/test_otel_metric_export_timeout.py
Comment thread manifests/php.yml Outdated
Comment thread tests/parametric/otel_env_vars/test_otel_metric_export_timeout.py Outdated
Comment thread tests/parametric/otel_env_vars/test_otel_metric_export_timeout.py Outdated
@vpellan
vpellan enabled auto-merge (squash) September 17, 2026 20:16
@vpellan
vpellan merged commit 480220d into main Sep 17, 2026
436 checks passed
@vpellan
vpellan deleted the vpellan/OTEL_METRIC_EXPORT_TIMEOUT branch September 17, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants