Skip to content

Auto-activate php easy wins for feature-flagging-and-experimentation-sdk - #7659

Open
dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
easy-win/feature-flagging-and-experimentation-sdk/php
Open

dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
easy-win/feature-flagging-and-experimentation-sdk/php

Conversation

@dd-octo-sts

@dd-octo-sts dd-octo-sts Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Automated activation of easy-win tests for php owned by feature-flagging-and-experimentation-sdk
View nightly workflow run

  • Auto-merge is only enabled for opted-in team/library pairs.
  • If the tests are failing it might be due to a change made since the last nightly system-tests run. You can close the PR, an updated one will be available tomorrow.
  • If you close the PR please also delete the branch

@dd-octo-sts
dd-octo-sts Bot marked this pull request as ready for review September 5, 2026 07:06
@dd-octo-sts
dd-octo-sts Bot requested a review from a team as a code owner September 5, 2026 07:06
@dd-octo-sts
dd-octo-sts Bot requested review from faydef and removed request for a team September 5, 2026 07:06
@dd-prapprover-prod-77c48c

dd-prapprover-prod-77c48c Bot commented Sep 5, 2026

Copy link
Copy Markdown

PRApprover will approve and merge this PR, FAQ, #dx-source-code-management

🛠️ PRApproval Status

  • ✅ PR is eligible for auto-approval by rule system-tests-auto-activate-easy-wins - 2026-09-22T06:42:18Z
  • ⬜ CI tests passed
  • ⬜ Approved
  • Manual merge required: this rule does not auto-merge.

➡️ Current phase: CI tests failed. Please fix the failing tests and rerun the workflow, click Workflow Link -> Workflow Starter Link -> Start Workflow

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/php.yml                                                       @DataDog/system-tests-reviewers

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e51f9aae8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread manifests/php.yml Outdated
tests/ffe/test_exposures_datadog_agent.py::Test_FFE_Exposure_Caching_Serial_Id_Disappears: missing_feature (EX-3425)
tests/ffe/test_exposures_datadog_agent.py::Test_FFE_Exposure_Caching_Serial_Id_Appears: # TODO: a lower version might be supported
- declaration: missing_feature (EX-3425)
component_version: <1.25.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Quote each <1.25.0 constraint

The four new component_version values containing < are unquoted, contrary to the repository's manifest YAML requirements. Quote this value as '<1.25.0' here and on lines 1255, 1261, and 1268 so the entries remain conformant across manifest validation and YAML tooling.

AGENTS.md reference: AGENTS.md:L7-L9

Useful? React with 👍 / 👎.

@datadog-official

datadog-official Bot commented Sep 5, 2026

Copy link
Copy Markdown

Pipelines  Tests

Unblock PR with BitsAI

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 12 Pipeline jobs failed

Testing the test | System Tests (php, dev) / End-to-end #1 / apache-mod-7.0 1 — ❌ 1 test failed

View more details · View in GitHub Actions

❌ tests.ffe.test_exposures_datadog_agent.Test_FFE_Exposure_Serial_Id.test_ffe_exposure_serial_id[apache-mod-7.0] from system_tests_suite
AssertionError: Timed out waiting for exposure event for flags [&#39;serial-id-absent-flag&#39;] and subject &#39;serial-id-user&#39;
assert False
 &#43;  where False = &lt;bound method ProxyBasedInterfaceValidator.wait_for of AgentInterfaceValidator(&#39;agent&#39;)&gt;(&lt;function wait_for_exposure_event.&lt;locals&gt;.&lt;lambda&gt; at 0x7f47b6697ec0&gt;, timeout=30)
 &#43;    where &lt;bound method ProxyBasedInterfaceValidator.wait_for of AgentInterfaceValidator(&#39;agent&#39;)&gt; = AgentInterfaceValidator(&#39;agent&#39;).wait_for
 &#43;      where AgentInterfaceValidator(&#39;agent&#39;) = interfaces.agent

self = &lt;tests.ffe.test_exposures_datadog_agent.Test_FFE_Exposure_Serial_Id object at 0x7f47e01c9af0&gt;

    def test_ffe_exposure_serial_id(self) -&gt; None:
        &#34;&#34;&#34;Test that serial_id carries the split value, and is omitted when the split has none.&#34;&#34;&#34;
...
Testing the test | System Tests (php, dev) / End-to-end #1 / apache-mod-7.4 1 — ❄️ 1 known flaky test

View more details · View in GitHub Actions

↳ ❄️ Known flaky: tests.ffe.test_exposures_datadog_agent.Test_FFE_Exposure_Serial_Id.test_ffe_exposure_serial_id[apache-mod-7.4] from system_tests_suite

Testing the test | System Tests (php, dev) / End-to-end #1 / apache-mod-7.4-zts 1 — ❌ 1 test failed

View more details · View in GitHub Actions

❌ tests.ffe.test_exposures_datadog_agent.Test_FFE_Exposure_Serial_Id.test_ffe_exposure_serial_id[apache-mod-7.4-zts] from system_tests_suite
AssertionError: Timed out waiting for exposure event for flags [&#39;serial-id-absent-flag&#39;] and subject &#39;serial-id-user&#39;
assert False
 &#43;  where False = &lt;bound method ProxyBasedInterfaceValidator.wait_for of AgentInterfaceValidator(&#39;agent&#39;)&gt;(&lt;function wait_for_exposure_event.&lt;locals&gt;.&lt;lambda&gt; at 0x7faf08169ee0&gt;, timeout=30)
 &#43;    where &lt;bound method ProxyBasedInterfaceValidator.wait_for of AgentInterfaceValidator(&#39;agent&#39;)&gt; = AgentInterfaceValidator(&#39;agent&#39;).wait_for
 &#43;      where AgentInterfaceValidator(&#39;agent&#39;) = interfaces.agent

self = &lt;tests.ffe.test_exposures_datadog_agent.Test_FFE_Exposure_Serial_Id object at 0x7faf31782240&gt;

    def test_ffe_exposure_serial_id(self) -&gt; None:
        &#34;&#34;&#34;Test that serial_id carries the split value, and is omitted when the split has none.&#34;&#34;&#34;
...

View all 12 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b020aba | Docs | View more details | Give us feedback!

@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/feature-flagging-and-experimentation-sdk/php branch 6 times, most recently from 5e6d4eb to fbd8960 Compare September 13, 2026 06:43
@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/feature-flagging-and-experimentation-sdk/php branch 7 times, most recently from 69adab1 to 9ee48cd Compare September 21, 2026 06:44
…tation-sdk

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/feature-flagging-and-experimentation-sdk/php branch from 9ee48cd to b020aba Compare September 22, 2026 06:42

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants